Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boxel UI components: ColorPicker, ColorPalette #2011

Merged
merged 14 commits into from
Jan 9, 2025

Conversation

jurgenwerk
Copy link
Contributor

@jurgenwerk jurgenwerk commented Jan 7, 2025

Adds 2 components that will help with composing color fields in Boxel:

image image

Color spectrum open:
image

The work that follows will be using this in the Blog Category, Pill color field (design screenshot):

image

Copy link

github-actions bot commented Jan 7, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   21m 8s ⏱️ +10s
727 tests ±0  725 ✔️ ±0  2 💤 ±0  0 ±0 
732 runs  ±0  730 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 952b33c. ± Comparison against base commit f12d695.

♻️ This comment has been updated with latest results.

@jurgenwerk jurgenwerk marked this pull request as ready for review January 8, 2025 09:54
@jurgenwerk jurgenwerk requested a review from a team January 8, 2025 09:54
Copy link
Contributor

@tintinthong tintinthong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice excited to use it

Has this been implemented in blog category or is this in another PR?? I can't see the change

Also, as part of the integration to blog category, it will be helpful to uadd a ColorField in experiments_field_preview card?? Thats where we have been collection all the fields that are used across apps.

@jurgenwerk
Copy link
Contributor Author

jurgenwerk commented Jan 8, 2025

@tintinthong I'll have a PR up for the blog category after this one, probably tomorrow morning. I'll check the experiments field preview

@jurgenwerk jurgenwerk merged commit c646313 into main Jan 9, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants