Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance component readability #2008

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

lucaslyl
Copy link
Contributor

@lucaslyl lucaslyl commented Jan 7, 2025

linear: https://linear.app/cardstack/issue/CS-7761/enchance-activity-card

  • simplify the card component with yield header and content
Screenshot 2025-01-07 at 15 56 53

@lucaslyl lucaslyl self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Host Test Results

    1 files  ±0      1 suites  ±0   21m 12s ⏱️ +13s
721 tests ±0  719 ✔️ ±0  2 💤 ±0  0 ±0 
726 runs  ±0  724 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit b56e12a. ± Comparison against base commit 5f92e67.

♻️ This comment has been updated with latest results.

@richardhjtan
Copy link
Contributor

@lucaslyl I assume that is no component uses it yet so it won't affected?

@lucaslyl
Copy link
Contributor Author

lucaslyl commented Jan 7, 2025

@lucaslyl I assume that is no component uses it yet so it won't affected?

yes, I just pushed another commit to remove the dummy activity card, so it won't affect anything now.

@tintinthong tintinthong merged commit 2f93df0 into main Jan 7, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants