Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover art support 4 #4

Open
wants to merge 75 commits into
base: coverArtSupport
Choose a base branch
from
Open

Cover art support 4 #4

wants to merge 75 commits into from

Conversation

cardinot
Copy link
Owner

@cardinot cardinot commented Aug 4, 2014

  • basic UI to download and show covers (dlgcoverartfetcher)
  • download covers from Last.fm
  • storing downloaded covers in the track dir

cardinot added 30 commits July 24, 2014 21:30
@cardinot
Add DlgCoverArtFetcher classes
8a5b684
@cardinot
Add Last.fm dependence (liblastfm)
814aa98
@cardinot
dlgcoverartfetcher.ui - initial layout
0a8b511
@cardinot
dlgcoverartfetcher.ui - improving layout + rename fields
e6502aa
@cardinot
Searching covers in the Last.fm database - initial implementation (ju…
10f0a8e 
…st getting cover_urls)
@cardinot
Revert "Add Last.fm dependence (liblastfm)"
dd73d12 
This reverts commit 814aa98.
@cardinot
dlgcoverartfetcher - downloading covers from url and loading them in …
1b5ef0c 
…a pixmap
@cardinot
Improving dlgcoverartfetcher.ui + add tableview (coverview)
702250d
@cardinot
Showing results at coverview (insert a pushbutton for each cell)
5753987
@cardinot
setting up coverView
4c0365b
@cardinot
small fix: coverView->setEditTriggers must use EditTrigger enum
e9af59b
@cardinot
implement toggle button to abort the search
6eb8e00
@cardinot
Aborting the search when the user close the dlgcoverfetcher
6796f13
@cardinot
Fixing bug with the status of the search_button
c324729
@cardinot
Removing unused members
47487bb
@cardinot
using title as album_name when "album && artist" are empty
32f65d3
@cardinot
add prev and next buttons to the dlgcoverartfetcher
4c9ed82
@cardinot
dlgcoverfetcher - disable txtArtist and txtAlbum when it is searching…
61f1070 
… covers
@cardinot
restore search button after a download error
5627e3d
@cardinot
Improving management of the cover search results
ac1f426 
- the last logic to handle the results was too complex...
@cardinot
dlgcoverfetcher.UI - small fix: display ALBUM field in the first row
1de1bae
@cardinot
small fix: restoring btnSearch after downloadFinished
6e2369a
@cardinot
cleaning the coverview always when a new search starts + add small co…
fe0de63 
…mment
@cardinot
dlgcoverfetcher - rename button - from "cancel" to "close"
b5ec417
@cardinot
Merge branch 'master' of https://github.com/mixxxdj/mixxx into coverA…
7d6f93b 
…rtSupport_4
@cardinot
Uptading DlgTrackinfo + DlgCoverFetcher + DlgTagFetcher together afte…
546ee62 
…r hit PREV or NEXT buttons

It avoids the bug #1349017
@cardinot
removing unnecessary slots of PREV and NEXT buttons
27248d8
@cardinot
Merge branch 'coverArtSupport_3' of https://github.com/cardinot/mixxx …
8fc3f7b 
…into coverArtSupport_4
@cardinot
Add searchCoverFromInternet action in the context menu
96a3d44
@cardinot
dlgcoverfetcher - add button to apply modifications (just UI)
a347052 
I realized that firstly I need to improve the tableview and then make the slot work properly...
Anyway, let's leave it done...
cardinot added 28 commits August 8, 2014 14:15
@cardinot
improving status management (clean-up)
da7a4d7
@cardinot
removing list with results from search + handling everything only wit…
4cabb12 
…h m_downloadQueue

As we are showing the results dynamically, we do not need to maintain the results in a list any more.
@cardinot
implements DlgCoverArtFetcher::slotApply (save and load downloaded co…
c468005 
…ver)

- storing cover in trackDir as cover.jpg|album.jpg|mixxx-cover.jpg
@cardinot
cosmetic fix - fixing member names
4a51cb5
@cardinot
Set status whne no images were found + clear status_bar when editing …
35837fa 
…finished
@cardinot
cosmeti fix - removing tabs (using only spaces)
9a070e6
@cardinot
DlgCoverArtFetcher - using QListWidget instead of QTableView (needs m…
cff34ce 
…ore work)

The logic used to make the qtableview works was overly complicated.
Using QListWidget we can do the same thing (add icons and text) just with a couple of lines.
Also, QListWidget will allow us to make the dlg resizable...
@cardinot
DlgCoverFetcher - setting up coverview (qlistwidget)
0f4f5a0
@cardinot
DlgCoverFetcher.UI - changing initial size to fit 5 columns + making …
1fa7158 
…it resizable
@cardinot
coverView - truncate cover text (artist and album) to fit into the cell
9df2b84
@cardinot
coverView - add tooltip with album name
ae71a1c
@cardinot
dlgcoverartfetcher - ensures that search&dowload connections are uniq…
66c2173 
…ue + ensures that downloadqueue and networkreply are valid before using it

- it avoids some crashes caused by successive requests
@cardinot
fixing bug with the status change when ENTER is pressed from album or…
9963fa6 
… artist fields
@cardinot
Removing DlgCoverArtFetcher::initCoverView()
5910c38 
after the last changes in the coverView (using qlistwidget) this method became unnecessary because we could start doing the same thing (cleaning downloadqueue and the cover view) directly...
@cardinot
dlgcoverfetcher starts searching directly when init() is called (just…
a1ed9ae 
… when album OR arist are not empty)

- it improves the usability, avoiding extra clicks by the user
@cardinot
implements btnApply for the new coverView (same logic that it was usi…
86f5d25 
…ng before with the qtableview)
@cardinot
coverView - applying cover by double click
50e23a5
@cardinot
coverView - disable drag&drop mode
8286804
@cardinot
Merge branch 'coverArtSupport' of https://github.com/cardinot/mixxx i…
d2a16c7 
…nto coverArtSupport_4
@cardinot
cosmetic fix - fixing identation
4e4bfbd
@cardinot
dlgcoverfetcher - implements keyevent to handle ENTER key action
fc89bee 
ENTER key was pressed:
 - a cover is selected ? apply()
 - it is ready to search ? search()
 - it is searching ? abort()
@cardinot
coverView - deselect cover after editting albumORartist fields
e35e0fd 
it avoids picking up (pressing ENTER key) a cover selected from an old search
@cardinot
txt fields - using the signal textChanged() instead of editingfinished()
a482271 
the signal editingfinished is emitted only after focus loss and it is bad when the user press ENTER without release the field.
@cardinot
DlgCoverArtFetcher::slotApply - it ensures that the current item is n…
e46c591 
…ot NULL and is selected (before try changing cover)
@cardinot
dlgcoverfetcher - add new status "NETWORKERROR" + small fixes
c0d23b8 
- showing network error directly from qnetworkreply
@cardinot
Merge branch 'coverArtSupport' of https://github.com/cardinot/mixxx i…
db393db 
…nto coverArtSupport_4

Conflicts:
	res/mixxx.qrc
	src/dlgtrackinfo.cpp
	src/dlgtrackinfo.h
@cardinot
Fixing merge conflicts
8ff257b
@cardinot
Init DlgCoverFetcher into WCoverArtMenu + DlgCoverFetcher as singleton
260b074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cardinot