Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of CryptoSpec #976

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fix compilation of CryptoSpec #976

merged 2 commits into from
Jul 12, 2023

Conversation

ch1bo
Copy link
Collaborator

@ch1bo ch1bo commented Jul 11, 2023

The PR we merged via the Github Security Advisory fork was actually not compiling and failing tests


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

ch1bo added 2 commits July 11, 2023 17:51
sublistOf is also sometimes yielding the same list, so we discard same
length prefixes. Also, classifying empty lists helps in ensuring we have
actually non trivial cases.
@ch1bo ch1bo requested a review from pgrange July 11, 2023 15:57
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Test Results

331 tests   325 ✔️  21m 42s ⏱️
110 suites      6 💤
    5 files        0

Results for commit fbaa3eb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Transactions Costs

Sizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using arbitrary values and results are not fully deterministic and comparable to previous runs.

Metadata
Generated at 2023-07-11 16:24:07.404138192 UTC
Max. memory units 14000000
Max. CPU units 10000000000
Max. tx size (kB) 16384

Script summary

Name Hash Size (Bytes)
νInitial 2212a4ee618434b9b2f366d7c330dbdfb5c7072e793a850fd0de6ddd 4294
νCommit 69e1ccf9ad73dc6d37a5bc8de5aec86f3c4c1710fe5fd334e0e16b18 2124
νHead 8ae095dca4d14a1b8edffb37faa6c84ec60340fbf389a62f027e0b76 9355
μHead 33642a45c7fbb955ce1704ef09229bb211bf9af9980530db28c6aafe* 4148
  • The minting policy hash is only usable for comparison. As the script is parameterized, the actual script is unique per Head.

Cost of Init Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 4742 13.34 5.23 0.50
2 4947 16.41 6.41 0.55
3 5149 19.52 7.61 0.59
5 5565 23.42 9.05 0.65
10 6584 33.75 12.89 0.81
37 12124 99.69 37.84 1.76

Cost of Commit Transaction

This is using ada-only outputs for better comparability.

UTxO Tx size % max Mem % max CPU Min fee ₳
1 599 14.89 5.70 0.34
2 784 19.57 7.70 0.40
3 972 24.75 9.88 0.46
5 1348 36.07 14.56 0.61
10 2285 71.81 28.88 1.04
13 2828 98.11 39.18 1.35

Cost of CollectCom Transaction

Parties UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
1 57 815 27.81 10.80 0.49
2 114 1135 43.59 17.06 0.68
3 170 1454 61.83 24.36 0.89
4 227 1775 82.62 32.69 1.13

Cost of Close Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 673 19.33 8.77 0.40
2 813 20.27 9.68 0.42
3 969 21.67 10.94 0.45
5 1299 24.46 13.45 0.50
10 2125 31.12 19.62 0.64
50 8725 87.17 69.99 1.74

Cost of Contest Transaction

Parties Tx size % max Mem % max CPU Min fee ₳
1 676 24.34 10.47 0.45
2 841 26.06 11.84 0.48
3 997 28.20 13.38 0.52
5 1336 31.63 16.12 0.58
10 2161 40.20 22.97 0.74
44 7773 98.03 69.37 1.78

Cost of Abort Transaction

Some variation because of random mixture of still initial and already committed outputs.

Parties Tx size % max Mem % max CPU Min fee ₳
1 4857 22.40 9.38 0.61
2 5175 36.68 15.56 0.79
3 5497 53.86 23.04 0.99
4 5532 63.60 26.89 1.10
5 6139 96.71 41.73 1.50

Cost of FanOut Transaction

Involves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.

Parties UTxO UTxO (bytes) Tx size % max Mem % max CPU Min fee ₳
5 0 0 4764 8.66 3.57 0.46
5 1 57 4805 10.06 4.39 0.47
5 5 284 4943 15.64 7.69 0.55
5 10 570 5126 22.61 11.82 0.64
5 20 1138 5483 36.56 20.07 0.83
5 30 1708 5848 50.52 28.33 1.02
5 40 2277 6203 64.49 36.60 1.21
5 50 2844 6560 78.46 44.87 1.40
5 65 3699 7097 99.42 57.28 1.68

@ch1bo ch1bo requested review from v0d1ch and ffakenz July 12, 2023 05:51
@pgrange pgrange merged commit ab71c58 into master Jul 12, 2023
@pgrange pgrange deleted the advisory-fix-2 branch July 12, 2023 07:05
@pgrange
Copy link
Contributor

pgrange commented Jul 12, 2023

Approving and merging straight away to fix master ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants