-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Externally commit script utxo #903
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionThis is using ada-only outputs for better comparability.
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
c828a59
to
602d762
Compare
d387977
to
7d66857
Compare
Test Results317 tests +4 311 ✔️ +4 25m 18s ⏱️ + 5m 34s Results for commit cc4ab7d. ± Comparison against base commit 6a7c79a. This pull request removes 4 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
7d66857
to
dc70b10
Compare
f999ecb
to
408bbb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some comments to discuss together
5a204be
to
408bbb4
Compare
dc70b10
to
dc1436d
Compare
9a691df
to
f37c49a
Compare
44bbe6f
to
abe493c
Compare
5f97795
to
21658cb
Compare
0490cd3
to
d8a1942
Compare
21658cb
to
9d98f9b
Compare
572f5d3
to
22709ab
Compare
459c74e
to
402f605
Compare
e39ac2c
to
8726171
Compare
Also remove tests that were not covering all cases properly
These expand the original UTxO argument to a UTxO including witnesses. This way, we can pack the script UTxOs into the same value and the commit transaction creation will just work™.
There is no point in mixing multiple utxo into such an integrated scenario. Let's keep the test case on point for committing a script into a head end-to-end. Should we desire more combinations, a "lower level" test suite should be exercised.
Note that it's note safe to use unsafeHashableScriptData when the data was already serialized (as in the FromJSON instance).
Seemingly the previously used prop_validateToJSON was not checking the spec correctly (anymore) as there were at least two issues in the logs.yaml specification.
- It caused one test to fail and from the error outcome I could not see the actuall stack trace printed.
39b3e5c
to
cc4ab7d
Compare
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
To prepare for #903 we want to be able to combine outcomes of type `Wait` and `NewState`. This commit allows for that and provide a more cohesive Outcome algebra.
This PR adds the option for our users to commit a script utxo to the Head externally, enabling script utxos to be made available in a Hydra head.
🌴 Extend the HTTP endpoint data types to accept utxo with an optional script
witness
(like datum, redeemer and script)🌴 Generalize the Chain handler
draftTx
to build, balance and sign internally the drafted tx using utxos with script witnesses.🌴 Reject commit transaction requests including UTxO addressed to the internal wallet.