Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore: remove message persistence from network layer #1593

Closed
wants to merge 1 commit into from

Conversation

ffakenz
Copy link
Contributor

@ffakenz ffakenz commented Sep 2, 2024

This eliminates message storing/reading from disk.

Explores #1417

Failing CI demonstrates:

  • all hydra-node tests pass besides the network-resilience ones, which is expected.
  • curren hydra-cluster benchmarks just don't work anymore.
  • no network-test passed.

Conclusion: #1417 is not a solution to our problem, but it significantly increased the system's speed.
This leads us to question whether we should persist all network messages in any future solution.


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

This eliminates message storing/reading from disk.
@ffakenz ffakenz self-assigned this Sep 2, 2024
@ch1bo
Copy link
Collaborator

ch1bo commented Sep 2, 2024

I concur with your conclusion @ffakenz and we should close this PR and #1417 with "not planned"

@ch1bo ch1bo linked an issue Sep 2, 2024 that may be closed by this pull request
@ffakenz
Copy link
Contributor Author

ffakenz commented Sep 2, 2024

Closing because #1417 is marked as "not planned"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't persist the network messages and their acknowledgements
2 participants