Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example - Centralized Telescope with BLS Signatures #114
base: main
Are you sure you want to change the base?
Example - Centralized Telescope with BLS Signatures #114
Changes from 15 commits
51d994c
2d3d6d6
158395d
4f897da
f364f7e
036f467
c492c0a
a9a563b
d143670
bc95a15
ea2eeb9
bd151d4
9faf078
0f61dc5
0c09939
57d60c8
1d835ef
718dfcc
c63483a
b3aeba3
a15fd73
9237bcf
ef9affc
cf33101
8e0b3d5
a1ac0fe
13cb0b2
a815d9b
08b3873
35dae91
3df7bf6
c24c21b
3984938
72b7e0d
a994074
4b61ead
bac3cdd
7684e52
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you are not modifying the
valid_signatures
during iteration, it is more efficient and more idiomatic to useiter()
instead ofclone()
, that isThis way, you are avoiding unnecessary cloning (better memory efficiency).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since all these signatures are BLS signatures you could batch verify them!
You could implement this in
aggregate.rs
using blst's functionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BLS signatures have good randomness properties so you could use as elements of your prover sets the signatures directly, this function would just return the signature.to_bytes() (but it is 48B indeed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention was to use the byte representation of the signature as an element. Even, I changed the
DATA_LENGTH
to 48B. But, as we discussed previously, we can keep theDATA_LENGTH
as it is by hashing the signatures.