Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No proof generated #104

Open
2 tasks
rrtoledo opened this issue Dec 13, 2024 · 0 comments
Open
2 tasks

No proof generated #104

rrtoledo opened this issue Dec 13, 2024 · 0 comments
Assignees

Comments

@rrtoledo
Copy link
Collaborator

Context & versions

The lottery input parameters can be too big and no proof is generated.
This is because proof_size can be higher than set_size.

Steps to reproduce

Actual behavior

                lottery_probability > 1

Expected behavior

                lottery_probability <= 1

Tasks

@rrtoledo rrtoledo self-assigned this Dec 13, 2024
@rrtoledo rrtoledo added this to the Centralized scheme milestone Dec 13, 2024
@rrtoledo rrtoledo mentioned this issue Dec 13, 2024
9 tasks
tolikzinovyev added a commit that referenced this issue Dec 13, 2024
rrtoledo added a commit that referenced this issue Dec 16, 2024
## Content

The lottery parameters does not check that the computed proof size
`proof_size > lower_bound` or even `proof_size > set_size`.
This PR returns proof_size=lower_bound if the lower bound is lower than
the computed u.

## Pre-submit checklist

- Branch
    - [ ] Tests are provided (if possible)
    - [x] Commit sequence broadly makes sense
    - [x] Key commits have useful messages
- PR
    - [x] No clippy warnings in the CI
    - [x] Self-reviewed the diff
    - [x] Useful pull request description
    - [x] Reviewer requested
- Documentation
    - [ ] Update README file (if relevant)
    - [ ] Update documentation website (if relevant)

## Comments
We will chech that lower_bound < set_size in issue #6 
 
## Issue(s)

<!-- The issue(s) this PR relates to or closes -->

Relates to #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant