Optimizations #780
Open
Optimizations #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got rid of sed cat and tr commands in favour of native parameter and variable expansions added declare specifier to explicitly show where variable is being declared and also if its modifiable or no via -r or readonly switch printf to echo to be closer to bashism as per #!/bin/bash request right at the top switch testing to empty string while [[ $var == "" ]] to more bash friendly [ -z "$var" ]
got rid of some external commands and further improvements
👷 Deploy request for testnets-cardano pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? (required)
most external commands replaced with bash builtin
formatted to look more bash friendly
Why? (optional)
Why has this change occurred if applicable?
How can this be tested? (optional)
Describe how this change can be tested
Screenshots (optional)
Upload some screenshots of the changes