Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOWNodes to Showcase #1149

Closed
wants to merge 7 commits into from

Conversation

AnnaNodes
Copy link

@AnnaNodes AnnaNodes commented Sep 22, 2023

Checklist

Showcase addition

  • Title: NOWNodes
  • Description: Get instant access to Cardano RPC nodes, indexer, and WebSocket connection. Start seamless integration on a FREE tariff plan. You can focus on growing your web3 products with us.
  • Website: https://nownodes.io
  • Source: https://nownodes.io/nodes/cardano-ada
  • Tags:
    • daotool
    • explorer

@rphair
Copy link
Collaborator

rphair commented Sep 23, 2023

Some review already in #1148.

@rphair rphair changed the title Add NOWNodes to showcases.js Add NOWNodes to Showcases Sep 23, 2023
@rphair rphair changed the title Add NOWNodes to Showcases Add NOWNodes to Showcase Sep 23, 2023
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inclusion of Cardano among the many blockchains supported by this service seems relatively insignificant, so likewise I don't see how this service is significant to Cardano. If you offer some distinctive support of Cardano then @AnnaNodes please post a Cardano specific link here and/or include it in your listing to better support your request.

src/data/showcases.js Outdated Show resolved Hide resolved
src/data/showcases.js Outdated Show resolved Hide resolved
@rphair rphair added the showcase Indicates a PR/issue on showcase label Sep 23, 2023
@AnnaNodes
Copy link
Author

Thank you! Fixed everything with your suggestions. Hope it looks appropriate now.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the submission @AnnaNodes - personally I don't think the Dev Portal needs another node provider, especially given @rdlrt's observations about the inadequate free tier pointed out in #1148 (comment), but I'll follow this listing & support it if any other reviewer makes a case otherwise.

@katomm
Copy link
Member

katomm commented Dec 4, 2023

The pull request has not received the required approvals and is closed. However, it can be opened again. Details on: https://developers.cardano.org/docs/portal-contribute/#how-are-pull-requests-reviewed

In any case, the discussion can be continued here.

@katomm katomm closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Indicates a PR/issue on showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants