Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): basic record to mark restore as complete #888

Merged
merged 22 commits into from
Jan 2, 2025
Merged

fix(core): basic record to mark restore as complete #888

merged 22 commits into from
Jan 2, 2025

Conversation

Sotatek-TungNguyen2a
Copy link
Collaborator

@Sotatek-TungNguyen2a Sotatek-TungNguyen2a commented Dec 30, 2024 •
edited
Loading

Description

This PR is reopened to resolve the remaining comments

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: no

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

@Sotatek-TungNguyen2a
feat: basic record to mark restore as complete
c8a68d4
@Sotatek-TungNguyen2a
Merge remote-tracking branch 'origin/develop' into feat/DTIS-1540-bas…
7e210dc 
…ic-record-to-mark-restore-as-complete
@Sotatek-TungNguyen2a
feat: mark done when finished recovering in the DB
b7d4337
@Sotatek-TungNguyen2a
feat: update unittest
9bca87c
@Sotatek-TungNguyen2a
Merge remote-tracking branch 'origin/develop' into feat/DTIS-1540-bas…
14fe07d 
…ic-record-to-mark-restore-as-complete
@Sotatek-TungNguyen2a
update: resolve comment
b88048a
@Sotatek-TungNguyen2a
update: update unit test
d6262a9
@Sotatek-TungNguyen2a
feat: resolve comment
db6fb03
@Sotatek-TungNguyen2a
Merge remote-tracking branch 'origin/develop' into feat/DTIS-1540-bas…
8dccd3f 
…ic-record-to-mark-restore-as-complete
@Sotatek-TungNguyen2a
Merge remote-tracking branch 'origin/develop' into feat/DTIS-1540-bas…
fd8b348 
…ic-record-to-mark-restore-as-complete
@Sotatek-TungNguyen2a
feat: resolve comment
d382f5e
@Sotatek-TungNguyen2a
Merge remote-tracking branch 'origin/develop' into feat/DTIS-1540-bas…
17411f0 
…ic-record-to-mark-restore-as-complete
@Sotatek-TungNguyen2a
feat: resolve comment
7575554
@Sotatek-TungNguyen2a
feat: call loadDatabase() after syncWithKeria and before startup app
200fe37
@Sotatek-TungNguyen2a
feat: remove unused import
e1f500a
@Sotatek-TungNguyen2a
Merge branch 'develop' into feat/DTIS-1540-basic-record-to-mark-resto…
e65967f 
…re-as-complete
@Sotatek-TungNguyen2a
update: remove unnecessary event references and resolve comment
0223f74
@iFergal iFergal requested a review from sdisalvo-crd as a code owner January 2, 2025 12:21
@iFergal iFergal merged commit 2a750e3 into develop Jan 2, 2025
1 check passed
@iFergal iFergal deleted the feat/DTIS-1540-basic-record-to-mark-restore-as-complete branch January 2, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdisalvo-crd sdisalvo-crd sdisalvo-crd approved these changes

@iFergal iFergal iFergal approved these changes

@jimcase jimcase Awaiting requested review from jimcase jimcase is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sotatek-TungNguyen2a @iFergal @sdisalvo-crd