Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): adjust black color #879

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Dec 19, 2024

Description

Adjust black color

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-1623

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Remove --ion-color-black-primary
Screenshot 2024-12-19 at 16 44 14
Remove --ion-color-black-primary-rgb
Screenshot 2024-12-19 at 16 44 46

Android

Remove --ion-color-black-primary

Screenshot_20241219_165336

Remove --ion-color-black-primary-rgb

Screenshot_20241219_165354

@Sotatek-DukeVu Sotatek-DukeVu removed the request for review from jimcase December 19, 2024 10:03
@Sotatek-DukeVu Sotatek-DukeVu self-assigned this Dec 19, 2024
@sdisalvo-crd sdisalvo-crd merged commit 23b25f2 into develop Dec 19, 2024
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-1623-adjust-black-color branch December 19, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants