Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): No witness availability #876

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Dec 19, 2024

Description

Display alert when no witness availability

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-1602

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Screenshot 2024-12-19 at 11 07 56

Android

Screenshot_20241219_111708

@Sotatek-DukeVu Sotatek-DukeVu force-pushed the feat/DTIS-1602-no-witness-availability branch from b853107 to c57dd24 Compare December 19, 2024 04:51
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 🚀

@sdisalvo-crd sdisalvo-crd merged commit 605c48a into develop Dec 19, 2024
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-1602-no-witness-availability branch December 19, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants