Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Use real credential miniature icons #872

Merged

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Dec 17, 2024

Description

Update cred miniature icon on archived credential and connection detail pages.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: DTIS-1593

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Identifier Color Selector
Screenshot 2024-12-17 at 11 51 55
Archived Credential
Screenshot 2024-12-17 at 13 52 05
Connection History
Screenshot 2024-12-17 at 11 58 56
Password Meter Color
Screenshot 2024-12-17 at 16 39 55
Unread Notification Color
Screenshot 2024-12-17 at 16 39 32
Connect Wallet Modal BG
Screenshot 2024-12-17 at 16 43 04

Android

Identifier Color Selector

Screenshot_20241217_141036

Archived Credential

Screenshot_20241217_141049

Connection History

Screenshot_20241217_140902

Password Meter Color

Screenshot_20241217_164959

Unread Notification Color

Screenshot_20241217_164939

Connect Wallet Modal BG

Screenshot_20241217_165059

Browser

Revoke Credential Before Accepted
Screenshot 2024-12-17 at 17 07 07
Group Request
Screenshot 2024-12-17 at 16 58 22

sdisalvo-crd
sdisalvo-crd previously approved these changes Dec 17, 2024
@sdisalvo-crd sdisalvo-crd merged commit ca483e2 into develop Dec 18, 2024
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the feat/DTIS-1593-use-real-credential-miniature-icons branch December 18, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants