feat: group ipex presentations (offer, grant) with leader #866
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to group IPEX presentations based on recent discusses in WebOfTrust/keripy#884. Now the core expects the group initiator to reply with
/ipex/offer
and/ipex/grant
messages first, and other members to join. Also takes the simplifications of letting KERIA track who has joined, rather than locally, like in the recent receive credential ticket.The UI for this is vastly different, so I've made some adjustments to get this working e2e but will of course require a lot of UI changes, refactoring and simplifications.
2 follow up PR notes:
/ipex/*
notification is deleted before the final/multisig/exn
message is received (i.e. long running operation checked before notifications checked), we end up with an "out of order" notification that re-tries forever. So the initiator tends to get constant errors in the console. This doesn't happen the receive credential (unless you delete the pending credential) because we check if the credential exists. My plan here across the board is to check the IPEX history on KERIA. This means we need to store/ipex/agree
history items, but hide from the UI - right now we aren't storing it.Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review