-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): ensure KEL, ACDC, contact timestamps are used instead of record creation time #860
feat(core): ensure KEL, ACDC, contact timestamps are used instead of record creation time #860
Conversation
In the UI const newIdentifier: IdentifierShortDetails = {
id: identifier,
displayName: identifierData.displayName,
createdAtUTC: new Date().toISOString(),
theme: selectedTheme,
isPending: isPending,
}; Should we set the const identifierDetail = await this.props.signifyClient.identifiers().get(identifier);
new Date(identifierDetail.state.dt) |
@jimcase The state could be the datetime of a newer rotation event. But yes, this is what myself and Patrick mentioned this morning. I opened a PR just now on KERIA: WebOfTrust/keria#335 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to wait until next dev release of KERIA for latest change to get the real inception datetime.
@jimcase I also misread your comment. Yes, except Bao's current PR is changing it so that it's created via callbacks so we can consolidate the two PRs. @Sotatek-BaoHoanga and @Sotatek-TungNguyen2a please coordinate here |
Description
In many places where we create records we are letting the createdAt timestamp be Date.now() but it should match the KERIA times.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review