QA/DTIS-419-generate-seed-phrase #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdisalvo-crd
approved these changes
Nov 28, 2023
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-1ascqjtme.vercel.app |
| @@ -19,6 +19,7 @@ const Alert = ({ | |||
|
|
|||
| if (confirmButtonText && actionConfirm) { | |||
| buttons.push({ | |||
| id: "confirm-alert-button", | |||
There was a problem hiding this comment.
The only thing I am not sure about is what's going to happen if you have two Alert with the same id in one page.
You could be more specific using the dataTestId prop and making your buttons something like: id: dataTestId + "-confirm-button" but it's up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new scenarios for generate seed phrase screen
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review