Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replaced profile image in the credential-issuance-server #267

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

jorgenavben
Copy link
Member

Description

Replaced profile picture used by the resident-card-with-expiration.json

The photo selected comes from this service that offers free stock photos.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: [link]

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Copy link

Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-prr390am1.vercel.app

@jorgenavben jorgenavben merged commit 79d2176 into develop Nov 27, 2023
1 check passed
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that:

1- The posture isn't what's usually associated with official documents (i.e. head and shoulders oriented to the camera, not smiling or showing teeth).
2- The image was supposed to be grayscale.

Did you run this through @robsalaman ?

jorgenavben added a commit that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants