refactor: Review repository impl and structure #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-gbofwrl2a.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-6v0e6g8gp.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-r5j9h2rwz.vercel.app |
iFergal
changed the title
sdisalvo-crd
previously approved these changes
Nov 21, 2023
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-2x5sr00yx.vercel.app |
jimcase
previously approved these changes
Nov 22, 2023
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-1rk8sf25c.vercel.app |
jimcase
previously approved these changes
Nov 23, 2023
sdisalvo-crd
previously approved these changes
Nov 23, 2023
…/DTIS-452-Review-Repository
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-8ndhws2sg.vercel.app |
sdisalvo-crd
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a general refactor on the repository to clean up the organisation a bit. There are a lot of file changes but most are smaller/import updates.
The
coredirectory only has minor refactoring/doc updates,enum CredentialTypeis now in the core as the core should never import from the UI, always vice versa.Structure outside of
./src:assetsis moved intosrcand README updatediconsremoved as redundantservicesdirectory now contains the cred issuance server and webrtc relay - anything our wallet depends on externally should go here, and other directories relate to building the mobile app.__mocks__moved to./src/ui/__mocks__which is more appropriate and still works.UI:
./src/utilsinto the existing./src/ui/utilsas it makes more sense there.globalsdirdictionary.tsis nowglobals/types.tsand only contains types.toastMsgRedux value and reducer that displays the current toast message. Before, toasts were of typestringand used the operation type (which was of string) - these were mixed up way too much, and TS wasn't helping since everything is a string - we should always use an enum or something here. So we also now have anOperationTypeenum. This is the biggest change of this PR.Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review