fix(ui): DTIS-450 removal crypto UI and deps #259
Conversation
…o-feature-removal-Blockfrost-URL-etc # Conflicts: # src/ui/constants/dictionary.ts
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-mm5svl81r.vercel.app |
There was a problem hiding this comment.
There is some stuff you have forgot to remove.
1- In the dictionary.ts file, check anything that is related to crypto and wallets in operationState and toastState.
2- In the GenerateSeedPhrase.tsx file, we are detecting if the user is generating a wallet for the onboarding or if they are generating a crypto wallet. I'd double check all logic that makes use of stateOnboarding and seedPhraseType.
I would also check VerifySeedPhrase for the use of the same 2 things above just in case.
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-kcua5zul1.vercel.app |
iFergal
changed the title
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-ix0arlhfo.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-jpmb0voof.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-o9vqvt5jb.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-18kbyuauv.vercel.app |
There was a problem hiding this comment.
@jimcase Please check TabsRoutePath in src/routes/paths.ts. We should remove CRYPTO_PLACEHOLDER = "/tabs/cryptoplaceholder", and just leave Crypto, same for the pages.
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-267zj5xs5.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-d43um0wl0.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-a9q40ould.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-5hh126ww5.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-olpqqccit.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-gxg8zilzn.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-qb6hk2yjp.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-p1od6vbdh.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-pc57i8jk5.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-ro3ynq7j7.vercel.app |
iFergal
deleted the
fix/DTIS-450-Crypto-feature-removal-Blockfrost-URL-etc
branch
Description
We have temporarily removed cryptocurrency-related UI components from our user interface. This decision, though temporary, is a strategic move to allow us the necessary time to develop a more concrete and comprehensive plan for integrating crypto features in a way that aligns with our core values and meets the evolving needs.
Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review
Design Review