fix: cardano connect stop showing newly joined group identifier in list

cardano-foundation · Sep 12, 2024 · b383fc1 · b383fc1
1 parent 27e2f2f
commit b383fc1
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/src/core/agent/agent.types.ts b/src/core/agent/agent.types.ts
@@ -185,6 +185,7 @@ interface AgentServicesProps {
 interface CreateIdentifierResult {
   signifyName: string;
   identifier: string;
+  multisigManageAid?: string;
   isPending?: boolean;
 }
 

diff --git a/src/core/agent/services/multiSigService.test.ts b/src/core/agent/services/multiSigService.test.ts
@@ -708,6 +708,7 @@ describe("Multisig sig service of agent", () => {
     ).toEqual({
       identifier: multisigIdentifier,
       isPending: true,
+      multisigManageAid: "id",
       signifyName: expect.any(String),
     });
 

diff --git a/src/core/agent/services/multiSigService.ts b/src/core/agent/services/multiSigService.ts
@@ -530,7 +530,12 @@ class MultiSigService extends AgentService {
       notificationId,
       notificationRoute
     );
-    return { identifier: multisigId, signifyName, isPending };
+    return {
+      identifier: multisigId,
+      multisigManageAid: identifier.id,
+      signifyName,
+      isPending,
+    };
   }
 
   @OnlineOnly

diff --git a/src/ui/pages/NotificationDetails/components/MultiSigRequest/MultiSigRequest.tsx b/src/ui/pages/NotificationDetails/components/MultiSigRequest/MultiSigRequest.tsx
@@ -103,7 +103,7 @@ const MultiSigRequest = ({
         "Cannot accept a multi-sig inception event before details are loaded from core"
       );
     } else {
-      const { identifier, signifyName, isPending } =
+      const { identifier, multisigManageAid, signifyName, isPending } =
         (await Agent.agent.multiSigs.joinMultisig(
           notificationDetails.id,
           notificationDetails.a.r as NotificationRoute,
@@ -121,6 +121,7 @@ const MultiSigRequest = ({
           createdAtUTC: `${notificationDetails?.createdAt}`,
           theme: multisigIcpDetails.ourIdentifier.theme,
           isPending: !!isPending,
+          multisigManageAid,
           signifyName,
         };
         const filteredIdentifiersData = identifiersData.filter(