feat(ui): Rare Evo clean up (#901)

* feat(ui): clean RareEvo card * feat(ui): remove rare evo image --------- Co-authored-by: Vu Van Duc <[email protected]>
cardano-foundation · Jan 13, 2025 · 6b53db1 · 6b53db1
1 parent fbe48d3
commit 6b53db1
Show file tree

Hide file tree

Showing 21 changed files with 41 additions and 482 deletions.
diff --git a/src/core/agent/services/connectionService.test.ts b/src/core/agent/services/connectionService.test.ts
@@ -812,15 +812,15 @@ describe("Connection service of agent", () => {
     };
     const mockHistoryIpexMessage = {
       id: "id",
-      credentialType: "rare evo",
+      credentialType: "lei",
       historyType: ConnectionHistoryType.CREDENTIAL_ISSUANCE,
       type: ConnectionHistoryType.CREDENTIAL_ISSUANCE,
       dt: new Date().toISOString(),
       connectionId: "connectionId",
     };
     const mockHistoryRevokeMessage = {
       id: "id",
-      credentialType: "rare evo",
+      credentialType: "lei",
       historyType: ConnectionHistoryType.CREDENTIAL_REVOKED,
       type: ConnectionHistoryType.CREDENTIAL_REVOKED,
       dt: new Date().toISOString(),

diff --git a/src/core/agent/services/ipexCommunicationService.ts b/src/core/agent/services/ipexCommunicationService.ts
@@ -56,9 +56,6 @@ class IpexCommunicationService extends AgentService {
   static readonly IPEX_ALREADY_REPLIED = "IPEX message has already been responded to or proposed to group";
   static readonly NO_CURRENT_IPEX_MSG_TO_JOIN = "Cannot join IPEX message as there is no current exn to join from the group leader";
 
-  static readonly SCHEMA_SAID_RARE_EVO_DEMO =
-    "EJxnJdxkHbRw2wVFNe4IUOPLt8fEtg9Sr3WyTjlgKoIb";
-
   protected readonly identifierStorage: IdentifierStorage;
   protected readonly credentialStorage: CredentialStorage;
   protected readonly notificationStorage: NotificationStorage;

diff --git a/src/ui/__fixtures__/connectionsFix.ts b/src/ui/__fixtures__/connectionsFix.ts
@@ -25,7 +25,7 @@ const connectionsFix: ConnectionDetails[] = [
       {
         type: 1,
         timestamp: "2017-01-14T19:23:24Z",
-        credentialType: "Rare EVO Attendee",
+        credentialType: "Cardano Foundation",
       },
     ],
   },

diff --git a/src/ui/__fixtures__/credsFix.ts b/src/ui/__fixtures__/credsFix.ts
@@ -58,7 +58,7 @@ const pendingCredFixs: ACDCDetails[] = [
       LEI: "5493001KJTIIGC8Y1R17",
     },
     s: {
-      title: "Rare EVO 2024 Attendee",
+      title: "Qualified vLEI Issuer Credential",
       description:
         "A vLEI Credential issued by GLEIF to Qualified vLEI Issuers which allows the Qualified vLEI Issuers to issue, verify and revoke Legal Entity vLEI Credentials and Legal Entity Official Organizational Role vLEI Credentials",
       version: "1.0.0",
@@ -85,7 +85,7 @@ const revokedCredFixs: ACDCDetails[] = [
       LEI: "5493001KJTIIGC8Y1R17",
     },
     s: {
-      title: "Rare EVO 2024 Attendee",
+      title: "Qualified vLEI Issuer Credential",
       description:
         "A vLEI Credential issued by GLEIF to Qualified vLEI Issuers which allows the Qualified vLEI Issuers to issue, verify and revoke Legal Entity vLEI Credentials and Legal Entity Official Organizational Role vLEI Credentials",
       version: "1.0.0",

diff --git a/src/ui/__fixtures__/filteredCredsFix.ts b/src/ui/__fixtures__/filteredCredsFix.ts
@@ -36,9 +36,9 @@ const filteredCredsFix: CredentialShortDetails[] = [
   {
     id: "EAzzrBvrVEYt3kvlXTZgulQhFq4CtkO8zA61eg6JtlMj",
     issuanceDate: "2024-10-21T12:35:26.597Z",
-    credentialType: "Rare EVO 2024 Attendee",
+    credentialType: "Qualified vLEI Issuer Credential",
     status: CredentialStatus.CONFIRMED,
-    schema: "EJxnJdxkHbRw2wVFNe4IUOPLt8fEtg9Sr3WyTjlgKoIb",
+    schema: "EBfdlu8R27Fbx-ehrqwImnK-8Cm79sqbAQ4MmvEAYqao",
     identifierType: IdentifierType.Group,
     identifierId: "EIRdVIgcPYj6LbN4DdxzJFnsvELV-7eWDBQ4a-VsRDQb",
   },

diff --git a/src/ui/__fixtures__/shortCredsFix.ts b/src/ui/__fixtures__/shortCredsFix.ts
@@ -58,18 +58,18 @@ const shortCredsFix: CredentialShortDetails[] = [
   {
     id: "EKfweht5lOkjaguB5dz42BMkfejhBFIF2-ghumzCJ6nv",
     issuanceDate: "2024-01-23T16:03:44.643Z",
-    credentialType: "Rare EVO 2024 Attendee",
+    credentialType: "Qualified vLEI Issuer Credential",
     status: CredentialStatus.CONFIRMED,
-    schema: "EJxnJdxkHbRw2wVFNe4IUOPLt8fEtg9Sr3WyTjlgKoIb",
+    schema: "EBfdlu8R27Fbx-ehrqwImnK-8Cm79sqbAQ4MmvEAYqao",
     identifierType: IdentifierType.Individual,
     identifierId: memberIdentifierRecord.id,
   },
   {
     id: "EKfweht5lOkjaguB5dz42BMkfejhBFIF3-ghumzCJ6nv",
     issuanceDate: "2024-01-23T16:03:44.643Z",
-    credentialType: "Rare EVO 2024 Attendee",
+    credentialType: "Qualified vLEI Issuer Credential",
     status: CredentialStatus.PENDING,
-    schema: "EJxnJdxkHbRw2wVFNe4IUOPLt8fEtg9Sr3WyTjlgKoIb",
+    schema: "EBfdlu8R27Fbx-ehrqwImnK-8Cm79sqbAQ4MmvEAYqao",
     identifierType: IdentifierType.Individual,
     identifierId: memberIdentifierRecord.id,
   },

diff --git a/src/ui/assets/images/rare-evo-bg.jpg b/src/ui/assets/images/rare-evo-bg.jpg
diff --git a/src/ui/components/ArchivedCredentials/CredentialItem.tsx b/src/ui/components/ArchivedCredentials/CredentialItem.tsx
@@ -7,13 +7,11 @@ import {
   IonLabel,
 } from "@ionic/react";
 import { CredentialStatus } from "../../../core/agent/services/credentialService.types";
-import { IpexCommunicationService } from "../../../core/agent/services/ipexCommunicationService";
 import { i18n } from "../../../i18n";
 import { formatShortDate } from "../../utils/formatters";
 import { CardTheme } from "../CardTheme";
 import "./ArchivedCredentials.scss";
 import { CredentialItemProps } from "./ArchivedCredentials.types";
-import BackgroundRAREVO from "../../assets/images/rare-evo-bg.jpg";
 
 const CredentialItem = ({
   credential,
@@ -25,8 +23,6 @@ const CredentialItem = ({
   onRestore,
 }: CredentialItemProps) => {
   const isRevoked = credential.status === CredentialStatus.REVOKED;
-  const isRareEvo =
-    credential.schema === IpexCommunicationService.SCHEMA_SAID_RARE_EVO_DEMO;
 
   return (
     <IonItemSliding>
@@ -45,19 +41,9 @@ const CredentialItem = ({
               aria-label=""
             />
           )}
-          {
-            isRareEvo ? (
-              <img
-                src={BackgroundRAREVO}
-                alt="credential-miniature"
-                className="credential-miniature"
-              />
-            ) : (
-              <div className="credential-miniature">
-                <CardTheme />
-              </div>
-            )
-          }
+          <div className="credential-miniature">
+            <CardTheme />
+          </div>
           <div className="credential-info">
             <div
               data-testid={`credential-name-${credential.id}`}

diff --git a/src/ui/components/CredentialCardTemplate/CredentialCardTemplate.test.tsx b/src/ui/components/CredentialCardTemplate/CredentialCardTemplate.test.tsx
@@ -1,37 +1,12 @@
-import { fireEvent, render } from "@testing-library/react";import { act } from "react";
+import { fireEvent, render } from "@testing-library/react";
+import { act } from "react";
 import { Provider } from "react-redux";
-import { CredentialCardTemplate } from "./CredentialCardTemplate";
 import { store } from "../../../store";
 import { shortCredsFix } from "../../__fixtures__/shortCredsFix";
-import { formatShortDate } from "../../utils/formatters";
+import { CredentialCardTemplate } from "./CredentialCardTemplate";
 
 
 describe("Credential Card Template", () => {
-  it("Renders Rare Evo Card Template", async () => {
-    const handleShowCardDetails = jest.fn();
-    const { getByText, getByTestId, getByAltText } = render(
-      <Provider store={store}>
-        <CredentialCardTemplate
-          name="name"
-          index={0}
-          cardData={shortCredsFix[5]}
-          isActive={true}
-          onHandleShowCardDetails={() => handleShowCardDetails(0)}
-        />
-      </Provider>
-    );
-    const card = getByTestId("rare-card-template-name-index-0");
-    expect(getByText(shortCredsFix[5].credentialType)).toBeInTheDocument();
-    expect(
-      getByText(formatShortDate(shortCredsFix[5].issuanceDate))
-    ).toBeInTheDocument();
-    expect(getByAltText(/card-logo/i)).toBeInTheDocument();
-    act(() => {
-      fireEvent.click(card);
-    });
-    expect(handleShowCardDetails).toBeCalledTimes(1);
-  });
-
   it("Renders Keri Card Template", async () => {
     const handleShowCardDetails = jest.fn();
     const { getByText, getByTestId, getByAltText } = render(

diff --git a/src/ui/components/CredentialCardTemplate/CredentialCardTemplate.tsx b/src/ui/components/CredentialCardTemplate/CredentialCardTemplate.tsx
@@ -1,22 +1,10 @@
-import { IpexCommunicationService } from "../../../core/agent/services/ipexCommunicationService";
-import { KeriCardTemplate, RareEvoCardTemplate } from "./components";
+import { KeriCardTemplate } from "./components";
 import { CredentialCardTemplateProps } from "./CredentialCardTemplate.types";
 
 const CredentialCardTemplate = ({
   name = "default",
   ...props
 }: CredentialCardTemplateProps) => {
-  if (
-    props.cardData.schema === IpexCommunicationService.SCHEMA_SAID_RARE_EVO_DEMO
-  ) {
-    return (
-      <RareEvoCardTemplate
-        name={name}
-        {...props}
-      />
-    );
-  }
-
   return (
     <KeriCardTemplate
       name={name}

diff --git a/...components/CredentialCardTemplate/components/RareEvoCardTemplate/RareEvoCardTemplate.scss b/...components/CredentialCardTemplate/components/RareEvoCardTemplate/RareEvoCardTemplate.scss