feat(core): create individual identifier reliability (incl: end role …

…auth) (#855) * feat: AC 3-5-6 * fix: update flow create individual identifier reliability * fix: resolve comment * fix: resolve comment * fix: update unit test for CreateIdentifier.tsx * fix: resolve comment * fix: make the function more idempotent * fix: get identifier metadata exist * fix: remove pending identifier in basic storage after creation * fix: resolve comment
cardano-foundation · Dec 18, 2024 · 4513b8d · 4513b8d
1 parent ca483e2
commit 4513b8d
Show file tree

Hide file tree

Showing 16 changed files with 678 additions and 183 deletions.
diff --git a/src/core/agent/agent.test.ts b/src/core/agent/agent.test.ts
@@ -35,6 +35,7 @@ const mockConnectionService = {
   resolvePendingConnections: jest.fn(),
 };
 const mockIdentifierService = {
+  resolvePendingIdentifier: jest.fn(),
   removeIdentifiersPendingDeletion: jest.fn(),
 };
 
@@ -158,6 +159,10 @@ describe("test cases of bootAndConnect function", () => {
     mockIdentifierService.removeIdentifiersPendingDeletion = jest
       .fn()
       .mockReturnValue(undefined);
+    mockIdentifierService.resolvePendingIdentifier = jest
+      .fn()
+      .mockReturnValue(undefined);
+
     await agent.bootAndConnect(mockAgentUrls);
 
     expect(signifyReady).toHaveBeenCalled();
@@ -274,6 +279,9 @@ describe("test cases of recoverKeriaAgent function", () => {
     mockIdentifierService.removeIdentifiersPendingDeletion = jest
       .fn()
       .mockReturnValue(undefined);
+    mockIdentifierService.resolvePendingIdentifier = jest
+      .fn()
+      .mockReturnValue(undefined);
 
     await agent.recoverKeriaAgent(mockSeedPhrase, mockConnectUrl);
 

diff --git a/src/core/agent/agent.ts b/src/core/agent/agent.ts
@@ -99,7 +99,8 @@ class Agent {
         this.agentServicesProps,
         this.identifierStorage,
         this.operationPendingStorage,
-        this.connections
+        this.connections,
+        this.basicStorage
       );
     }
     return this.identifierService;
@@ -335,6 +336,7 @@ class Agent {
       this.connections.removeConnectionsPendingDeletion();
       this.connections.resolvePendingConnections();
       this.identifiers.removeIdentifiersPendingDeletion();
+      this.identifiers.resolvePendingIdentifier();
     }
 
     this.agentServicesProps.eventEmitter.emit<KeriaStatusChangedEvent>({

diff --git a/src/core/agent/agent.types.ts b/src/core/agent/agent.types.ts
@@ -39,6 +39,7 @@ enum MiscRecordId {
   LOGIN_METADATA = "login-metadata",
   CAMERA_DIRECTION = "camera-direction",
   FAILED_NOTIFICATIONS = "failed-notifications",
+  IDENTIFIERS_PENDING_CREATION = "identifiers-pending-creation",
 }
 
 interface ConnectionShortDetails {

diff --git a/src/core/agent/event.types.ts b/src/core/agent/event.types.ts
@@ -1,4 +1,5 @@
 import { ConnectionStatus, KeriaNotification } from "./agent.types";
+import { IdentifierMetadataRecordProps } from "./records";
 import { OperationPendingRecord } from "./records/operationPendingRecord";
 import { OperationPendingRecordType } from "./records/operationPendingRecord.type";
 import {
@@ -21,6 +22,7 @@ enum EventTypes {
   KeriaStatusChanged = "KeriaStatusChanged",
   NotificationRemoved = "NotificationRemoved",
   IdentifierRemoved = "IdentifierRemoved",
+  IdentifierAdded = "IdentifierAdded",
 }
 
 interface NotificationAddedEvent extends BaseEventEmitter {
@@ -92,6 +94,13 @@ interface IdentifierRemovedEvent extends BaseEventEmitter {
   };
 }
 
+interface IdentifierAddedEvent extends BaseEventEmitter {
+  type: typeof EventTypes.IdentifierAdded;
+  payload: {
+    identifier: IdentifierMetadataRecordProps;
+  };
+}
+
 export type {
   NotificationAddedEvent,
   OperationCompleteEvent,
@@ -103,5 +112,6 @@ export type {
   NotificationRemovedEvent,
   ConnectionRemovedEvent,
   IdentifierRemovedEvent,
+  IdentifierAddedEvent,
 };
 export { EventTypes };
diff --git a/src/core/agent/records/identifierStorage.test.ts b/src/core/agent/records/identifierStorage.test.ts
@@ -85,4 +85,27 @@ describe("Identifier storage test", () => {
     );
     expect(storageService.update).toBeCalled();
   });
+
+  test("Should get all identifier pending deletion", async () => {
+    storageService.findAllByQuery.mockResolvedValue([
+      {
+        ...identifierMetadataRecord,
+        pendingDeletion: true,
+      },
+      {
+        ...identifierMetadataRecord2,
+        pendingDeletion: true,
+      },
+    ]);
+    expect(await identifierStorage.getIdentifiersPendingDeletion()).toEqual([
+      {
+        ...identifierMetadataRecord,
+        pendingDeletion: true,
+      },
+      {
+        ...identifierMetadataRecord2,
+        pendingDeletion: true,
+      },
+    ]);
+  });
 });
diff --git a/src/core/agent/records/identifierStorage.ts b/src/core/agent/records/identifierStorage.ts
@@ -56,7 +56,12 @@ class IdentifierStorage {
     metadata: Partial<
       Pick<
         IdentifierMetadataRecord,
-        "displayName" | "theme" | "isPending" | "isDeleted" | "groupMetadata" | "pendingDeletion"
+        | "displayName"
+        | "theme"
+        | "isPending"
+        | "isDeleted"
+        | "groupMetadata"
+        | "pendingDeletion"
       >
     >
   ): Promise<void> {