perf(core): filter by isDeleted for credentials using tag query (#786)

* feat(core): Filter by isDeleted for credentials using tag query * remove redundant comment
cardano-foundation · Oct 17, 2024 · 42dab78 · 42dab78
1 parent 2f8f84d
commit 42dab78
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/core/agent/records/credentialStorage.ts b/src/core/agent/records/credentialStorage.ts
@@ -15,6 +15,7 @@ class CredentialStorage {
     const records = await this.storageService.findAllByQuery(
       {
         ...(isArchived !== undefined ? { isArchived } : {}),
+        isDeleted: false,
       },
       CredentialMetadataRecord
     );

diff --git a/src/core/agent/services/credentialService.ts b/src/core/agent/services/credentialService.ts
@@ -49,13 +49,9 @@ class CredentialService extends AgentService {
     const listMetadatas = await this.credentialStorage.getAllCredentialMetadata(
       isGetArchive
     );
-    // Only get credentials that are not deleted
-    // @TODO - foconnor: Should be filtering via SQL for the deleted ones.
-    return listMetadatas
-      .filter((item) => !item.isDeleted)
-      .map((element: CredentialMetadataRecord) =>
-        this.getCredentialShortDetails(element)
-      );
+    return listMetadatas.map((element: CredentialMetadataRecord) =>
+      this.getCredentialShortDetails(element)
+    );
   }
 
   private getCredentialShortDetails(