Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: Add necessary test data files to windows testing bundle #958

Merged
merged 2 commits into from
Nov 6, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Nov 5, 2019

Relates to #703.

Overview

  • Includes test data in the zip file so that tests can pass.
  • Fixes launch.bat
  • Updates the Haskell.nix revision so that it's on the master branch, not a PR branch.

Comments

Testing procedure is in #703.

@rvl rvl self-assigned this Nov 5, 2019
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvl
Copy link
Contributor Author

rvl commented Nov 5, 2019

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 6, 2019
958: nix: Add necessary test data files to windows testing bundle r=rvl a=rvl

Relates to #703.

# Overview

- Includes test data in the zip file so that tests can pass.
- Fixes `launch.bat`
- Updates the Haskell.nix revision so that it's on the master branch, not a PR branch.

# Comments

Testing procedure is in #703.


Co-authored-by: Rodney Lorrimar <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 6, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit bc9a604 into master Nov 6, 2019
@KtorZ KtorZ deleted the rvl/703/fix-tests-data-windows branch November 6, 2019 14:50
@KtorZ KtorZ added this to the Usability & Compatibility milestone Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants