Fix coin selection max number of inputs not diminishing as expected #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paweljakubas
approved these changes
Jul 10, 2019
paweljakubas
force-pushed
the
KtorZ/522/coin-selection-options
branch
from
51ae115 to
f96bec8
Compare
Seems that we only respect the 'maximum number of inputs' for each output independantly, but not globally. See: #522
…prove algorithm This is because inputs are 'consumed' as we process outputs, so we gotta keep the number of allowed inputs in the loop and not only look at it as a global value.
3 tasks
piotr-iohk
pushed a commit
that referenced
this pull request
Jul 11, 2019
piotr-iohk
pushed a commit
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#522
Overview
largestFirstandrandomselection.CoinSelectionOptionto be part of the fold accumulator, so that it can be updated between each outputimprovepart so that it will also behave accordingly.Comments