Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add a couple negative tests for block decoding #48

Merged
merged 2 commits into from
Mar 12, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 12, 2019

Relates to #11.
Add some tests of decoding non-block data.

Copy link
Member

@jonathanknowles jonathanknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though still need to bring code in line with https://github.com/input-output-hk/cardano-wallet/wiki/Coding-Standards

@KtorZ KtorZ force-pushed the rvl/11/more-deserialise-tests branch from 4d26c62 to 97f3fad Compare March 12, 2019 11:25
@KtorZ
Copy link
Member

KtorZ commented Mar 12, 2019

@piotr-iohk I've fixed @jonathanknowles remarks & added a test to unserialize a block contains MANY (many = 2) transactions.

Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants