Use arbitraryBoundedEnum instead of genericArbitrary where possible.
#477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` type. Additionally, remove the dependency on `generic-arbitrary`.
jonathanknowles
force-pushed
the
jonathanknowles/arbitrary-bounded-enum
branch
from
97527b1 to
8d2e110
Compare
KtorZ
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
None, but a continuation of #468.
Overview
For pure enumeration data types with only nullary data constructors, we often auto-derive
BoundedandEnuminstances, and usearbitraryBoundedEnumto generate arbitrary values. However, there are a few instances that usegenericArbitrary.This PR fixes this inconsistency, removing dependencies on
generic-arbitrarywhere possible.