Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3397] Bump to node 9.1 #4703

Merged
merged 8 commits into from
Jul 26, 2024
Merged

[ADP-3397] Bump to node 9.1 #4703

merged 8 commits into from
Jul 26, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jul 25, 2024 •
edited
Loading

  • Bump node runtime version to 9.1.0
  • Remove all local-cluster node configuration discrimination based on current era
  • Update memory benchmark node configurations

ADP-3397

@paolino paolino added the Conway PRs to prepare to the Conway bump label Jul 25, 2024
@paolino paolino self-assigned this Jul 25, 2024
@paolino paolino force-pushed the paolino/ADP-3397/bump-to-node-9.1 branch 5 times, most recently from 647d12c to b058a5f Compare July 26, 2024 12:58
@paolino paolino marked this pull request as ready for review July 26, 2024 12:59
Anviking
Anviking reviewed Jul 26, 2024
View reviewed changes
justfile Outdated Show resolved Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Node/GenNodeConfig.hs Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3397/bump-to-node-9.1 branch from b058a5f to 9f7fedb Compare July 26, 2024 13:16
@paolino paolino requested a review from Anviking July 26, 2024 13:17
Anviking
Anviking reviewed Jul 26, 2024
View reviewed changes
justfile Outdated Show resolved Hide resolved
lib/local-cluster/lib/Cardano/Wallet/Launch/Cluster/Node/GenNodeConfig.hs Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3397/bump-to-node-9.1 branch from 9f7fedb to 3704398 Compare July 26, 2024 13:25
@paolino paolino requested a review from Anviking July 26, 2024 13:25
@paolino paolino force-pushed the paolino/ADP-3397/bump-to-node-9.1 branch from 3704398 to 8289ee4 Compare July 26, 2024 13:35
Anviking
Anviking approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@Anviking Anviking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@paolino paolino added this pull request to the merge queue Jul 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@paolino paolino added this pull request to the merge queue Jul 26, 2024
Merged via the queue into master with commit a3ff16c Jul 26, 2024
22 checks passed
@paolino paolino deleted the paolino/ADP-3397/bump-to-node-9.1 branch July 26, 2024 15:24
paweljakubas
paweljakubas approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@paolino paolino mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@Anviking Anviking Anviking approved these changes

Assignees

@paolino paolino

Labels
Conway PRs to prepare to the Conway bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paolino @Anviking @paweljakubas @HeinrichApfelmus