Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-3387] Add support for private network #4679

Merged
merged 9 commits into from
Jul 15, 2024
Merged

[ADP-3387] Add support for private network #4679

merged 9 commits into from
Jul 15, 2024

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jul 12, 2024 •
edited
Loading

  • Add private network configs
  • Add scripts to run the wallet on private network with docker or nix
  • Add E2E tests for full private network sync
  • Update the README quickstart to use the new run hierarchy

ADP-3387

@paolino paolino self-assigned this Jul 12, 2024
@paolino paolino added the CI CI related label Jul 12, 2024
@paolino paolino force-pushed the paolino/ADP-3387/add-support-for-private-network branch 6 times, most recently from 104ad0b to b568a97 Compare July 12, 2024 15:13
Base automatically changed from paolino/ADP-3386/remove-sanchonet-support to master July 12, 2024 15:26
@paolino paolino force-pushed the paolino/ADP-3387/add-support-for-private-network branch from b568a97 to 6a6bbd6 Compare July 12, 2024 16:51
@paolino paolino requested a review from HeinrichApfelmus July 12, 2024 16:52
@paolino paolino marked this pull request as ready for review July 12, 2024 16:52
@paolino paolino added the Docs Changing the docs label Jul 12, 2024
HeinrichApfelmus
HeinrichApfelmus approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! 😊 Could you merge my suggested changes to the text as well?

configs/cardano/private/download.sh Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@paolino paolino force-pushed the paolino/ADP-3387/add-support-for-private-network branch from 0f3ae6f to cc16e2f Compare July 15, 2024 12:37
@paolino paolino enabled auto-merge July 15, 2024 12:38
@paolino paolino added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@paolino paolino added this pull request to the merge queue Jul 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 15, 2024
@paolino paolino merged commit fe8a171 into master Jul 15, 2024
3 checks passed
@paolino paolino deleted the paolino/ADP-3387/add-support-for-private-network branch July 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeinrichApfelmus HeinrichApfelmus HeinrichApfelmus approved these changes

Assignees

@paolino paolino

Labels
CI CI related Docs Changing the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @HeinrichApfelmus