Implement Jörmungandr NetworkLayer postTx #463
Conversation
| @@ -140,6 +151,9 @@ data JormungandrLayer m = JormungandrLayer | |||
| :: Hash "BlockHeader" | |||
| -> Word | |||
| -> ExceptT ErrGetDescendants m [Hash "BlockHeader"] | |||
| , postMessage | |||
There was a problem hiding this comment.
- Avoids collision with
NetworkLayer.postTx - Coherent with the terminology of the API
- Signals that we could submit other messages
| @@ -92,7 +94,7 @@ type GetTipId | |||
| :> "tip" | |||
| :> Get '[Hex] BlockId | |||
|
|
|||
| type PostSignedTx | |||
| type PostMessage | |||
| @@ -92,7 +94,7 @@ type GetTipId | |||
| :> "tip" | |||
| :> Get '[Hex] BlockId | |||
|
|
|||
| type PostSignedTx | |||
| type PostMessage | |||
| = "v0" | |||
| :> "message" | |||
| :> ReqBody '[JormungandrBinary] (Tx, [TxWitness]) | |||
There was a problem hiding this comment.
Feels a bit weird though that we do postMesage, but the body has to be a signed transaction... Okay for now though...
| -> (Key 'AddressK XPrv, Passphrase "encryption") | ||
| -> TxWitness | ||
| sign (TxIn (Hash tx) _) (key, (Passphrase pwd)) = | ||
| sign (Hash tx) (key, (Passphrase pwd)) = | ||
| TxWitness . CC.unXSignature $ CC.sign pwd (getKey key) (block0 <> tx) |
There was a problem hiding this comment.
Changes to this file included in #464 already 👍
| runExceptT (postTx nw signedEmpty) `shouldReturn` Right () | ||
|
|
||
| it "tx from faucet succeeds" $ \(_, nw) -> do | ||
| let (Right mw) = mkMnemonic @15 ["tattoo","potato","foil","mutual","slab","path","forward","pencil","suit","marble","hill","meat","close","garden","bird"] |
There was a problem hiding this comment.
Let go for generateEntropy here instead of a hard-coded mnemonic 👍
There was a problem hiding this comment.
Okay, just saw the title now as I was wondering why you'd go for hard-coded addresses in the next tests but not in this one.
We shouldn't hard-coded a generated faucet mnemonic here, there are located in an opaque module for a reason :), they might (and will actually) change over time and they don't have any special semantic so no need to consider them in any particular way.
I think the test would read better if you simply provide some arbitrary inputs and outputs and show that a well-formed transaction can be submitted.
| describe "Submitting signed transactions" $ beforeAll startNode' $ afterAll killNode $ do | ||
| it "empty tx succeeds" $ \(_, nw) -> do | ||
| let signedEmpty = (Tx [] [], []) | ||
| runExceptT (postTx nw signedEmpty) `shouldReturn` Right () |
| tl | ||
| (const $ Just (xprv, mempty)) | ||
| [ownedIn] | ||
| [txOut] |
There was a problem hiding this comment.
suggestion:
let keystore = const $ Just (xprv, mempty)
let (Right stx) = mkStdTx tl keystore [ownedIn] [txOut]
Anviking
force-pushed
the
anviking/219/posttx
branch
from
4db0977 to
bfc3921
Compare
Anviking
force-pushed
the
anviking/219/posttx
branch
from
bfc3921 to
6b3b37f
Compare
Anviking
force-pushed
the
anviking/219/posttx
branch
from
6b3b37f to
3c54caa
Compare
| , coin = Coin 933636862791 | ||
| } | ||
| , TxOut | ||
| { address = unsafeDecodeAddress proxy "ca1qwunuat6snw60g99ul6qvte98fjale2k0uu5mrymylqz2ntgzs6vs386wxd" |
|
|
||
| it "no input, one output" $ \(_, nw) -> do | ||
| let tx = (Tx [] | ||
| [ (TxOut $ unsafeDecodeAddress proxy "ca1qwunuat6snw60g99ul6qvte98fjale2k0uu5mrymylqz2ntgzs6vs386wxd") |
There was a problem hiding this comment.
| -- this should in practice be like appending bytes to the end of | ||
| -- the message. | ||
| let signed = (txNonEmpty, [pkWitness, pkWitness, pkWitness]) | ||
| runExceptT (postTx nw signed) `shouldReturn` Right () |
There was a problem hiding this comment.
Interesting as well. Maybe worth reporting to Jörmungandr?
There was a problem hiding this comment.
Issue Number
#219
Overview
JörmungandrLayerpostTxtopostMessageJörmungandrLayerpostMessageand NetworkLayerpostTxErrPostTxBadRequest.Comments
jcli rest v0 message logs -h http://127.0.0.1:8081/api. endpoint will silently succeed if