Use method for encryption method in ApiEncryptMetadata.
#4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
jonathanknowles/adp-322/simplify-api-encrypt-metadata-method
to
paweljakubas/adp-322/add-metadata-encryption-to-api
May 14, 2024 08:39
There was a problem hiding this comment.
I have qualms here to be frank. See CIP I want to comply with https://github.com/cardano-foundation/CIPs/tree/master/CIP-0083#format they use enc although I agree method is probably less surprising. Nevertheless, I would advocate we are obliged to comply here @jonathanknowles
paweljakubas
approved these changes
May 16, 2024
jonathanknowles
merged commit fbfb5a7
into
paweljakubas/adp-322/add-metadata-encryption-to-api
2 of 3 checks passed
jonathanknowles
deleted the
jonathanknowles/adp-322/rename-field-for-api-encrypt-metadata-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the name for the encryption method field for
ApiEncryptMetadatafromenctomethod.Justification
cardano-walletHTTP API, it's idiomatic to use complete words instead of shortenings such asenc.methodis consistent with the field typeApiEncryptMetadataMethod.methodis (arguably) more self-documenting thanenc.Issue
ADP-322