-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADP-3302] Bump compile-time dependencies to match cardano-node-8.9. #4503
Merged
HeinrichApfelmus
merged 24 commits into
master
from
HeinrichApfelmus/ADP-3302/bump-node-3.9
Mar 25, 2024
Merged
[ADP-3302] Bump compile-time dependencies to match cardano-node-8.9. #4503
HeinrichApfelmus
merged 24 commits into
master
from
HeinrichApfelmus/ADP-3302/bump-node-3.9
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeinrichApfelmus
force-pushed
the
HeinrichApfelmus/ADP-3302/bump-node-3.9
branch
2 times, most recently
from
March 20, 2024 12:58
23b672c
to
bb36621
Compare
paolino
force-pushed
the
HeinrichApfelmus/ADP-3302/bump-node-3.9
branch
3 times, most recently
from
March 21, 2024 11:58
d5cfcef
to
79afc95
Compare
paolino
force-pushed
the
HeinrichApfelmus/ADP-3302/bump-node-3.9
branch
16 times, most recently
from
March 23, 2024 09:30
52588e4
to
148e42b
Compare
paolino
force-pushed
the
HeinrichApfelmus/ADP-3302/bump-node-3.9
branch
4 times, most recently
from
March 25, 2024 13:48
e2d3544
to
7c476b1
Compare
paolino
force-pushed
the
HeinrichApfelmus/ADP-3302/bump-node-3.9
branch
from
March 25, 2024 13:51
7c476b1
to
e2ea629
Compare
paolino
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
This reverts the switch made in the recent node bump out of precaution, as the behaviour of `estimateMinFeeTx` is different from that of `evaluateTransactionFee`. Task for later to properly address this: [ADP-3334 (Stop using deprecated ledger function `Shelley.evaluateTransactionFee`)](https://cardanofoundation.atlassian.net/browse/ADP-3334) ### Issue Number ADP-3302, follow-up to #4503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates our compile-time dependencies to match those of cardano-node-8.9.0.
Issue number
ADP-3302