Fix inconsistency between the current epoch in the tip and delegation status within the wallet API response #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te it from the node tip instead.
Unisay
force-pushed
the
yura/ADP-3216/inconsistent-tip
branch
from
1880956 to
e9a356e
Compare
HeinrichApfelmus
approved these changes
Nov 6, 2023
| ti = Slotting.expectAndThrowFailures $ timeInterpreter nl | ||
|
|
||
| getCurrentEpoch = | ||
| currentEpochFromWallClock >>= \case |
There was a problem hiding this comment.
Removing this is definitely more consistent. 👍
However, it may have an impact on Daedalus users: If the node has not fully synched yet, they will see an outdated delegation status. 🤔 But I think that this is ok — the network information endpoints tell user what tip the wallet sees, and it cannot reasonably look into the future. We may still want to record this as a "user-facing change", though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-3216