Move Write.Tx modules to cardano-balance-tx
#4127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
changed the base branch from
master
to
anviking/ADP-3081/ledger-tokenBundleSizeAssessor
Anviking
force-pushed
the
anviking/move-balanceTx-2
branch
6 times, most recently
from
17f57d3 to
d4228d5
Compare
Anviking
force-pushed
the
anviking/move-balanceTx-2
branch
from
d4228d5 to
5daa2ec
Compare
Anviking
commented
Sep 14, 2023
| deriving (Show, Eq) | ||
|
|
||
| assumedTxWitnessTag :: UTxOAssumptions -> TxWitnessTag | ||
| assumedTxWitnessTag = \case |
There was a problem hiding this comment.
Why not leave it in the UtxoAssumptions module?
There was a problem hiding this comment.
🤔 TxWitnessTag is ultimately only needed for SizeEstimation.hs-functions, and seems more internal to me. I'd favor not putting it in Write.UTxOAssumption now.
Base automatically changed from
anviking/ADP-3081/ledger-tokenBundleSizeAssessor
to
master
September 14, 2023 10:28
Anviking
force-pushed
the
anviking/move-balanceTx-2
branch
from
2893e4e to
235222c
Compare
jonathanknowles
approved these changes
Sep 15, 2023
Co-authored-by: Jonathan Knowles <[email protected]>
Anviking
force-pushed
the
anviking/move-balanceTx-2
branch
from
235222c to
d0f58df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std-gen-seedlibraryWrite.Txmodules tocardano-balance-txComments
Issue Number
ADP-3170