Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮 Remove adaMinimum field from ApiWalletUtxoSnapshotEntry type. #4084

Conversation

jonathanknowles
Copy link
Member

@jonathanknowles jonathanknowles commented Aug 9, 2023

Issue

ADP-3122

Summary

This PR removes the adaMinimum field from the ApiWalletUtxoSnapshotEntry type.

Context

The original purpose of this field was to aid debugging, and specifically to answer the following question:

“For a given UTxO that already exists, what would the ledger have required the minimum quantity of ada to be at the time the UTxO was originally created?”

In general this question is quite hard to answer, as for every historical UTxO that belongs to the wallet, we’d need to know:

  • in which era was this UTxO created?
  • at which slot (within an era) was this UTxO created?
  • what were the values of the protocol parameters at the time the UTxO was created?

This is because the minimum UTxO function can change:

  • as we transition from one era to another; and/or
  • whenever the protocol parameters are updated.

Finally, since:

  • this field is for debugging purposes only;
  • it has maintenance burden that is hard to satisfy;
  • it is an obstacle to ongoing work in other areas; and since
  • there is little evidence of user demand for this field,

We should feel free to remove it.

@jonathanknowles jonathanknowles changed the title Remove adaMinimum field from ApiWalletUtxoSnapshotEntry. Remove adaMinimum field from ApiWalletUtxoSnapshotEntry type. Aug 9, 2023
@jonathanknowles jonathanknowles changed the title Remove adaMinimum field from ApiWalletUtxoSnapshotEntry type. 🚮 Remove adaMinimum field from ApiWalletUtxoSnapshotEntry type. Aug 9, 2023
@jonathanknowles jonathanknowles marked this pull request as ready for review August 9, 2023 06:12
Copy link
Contributor

@Unisay Unisay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanknowles jonathanknowles added this pull request to the merge queue Aug 9, 2023
Merged via the queue into master with commit c25031d Aug 9, 2023
@jonathanknowles jonathanknowles deleted the jonathanknowles/remove-min-ada-field-from-wallet-utxo-snapshot branch August 9, 2023 09:37
WilliamKingNoel-Bot pushed a commit that referenced this pull request Aug 9, 2023
…ype. (#4084) ## Issue ADP-3122 ## Summary This PR removes the `adaMinimum` field from the `ApiWalletUtxoSnapshotEntry` type. ## Context The original purpose of this field was to aid debugging, and specifically to answer the following question: > “For a given UTxO that already exists, what would the ledger have required the minimum quantity of ada to be at the time the UTxO was originally created?” In general this question is quite hard to answer, as for every historical UTxO that belongs to the wallet, we’d need to know: - in which era was this UTxO created? - at which slot (within an era) was this UTxO was created? - what were the values of the protocol parameters at the time the UTxO was created? This is because the minimum UTxO function can change: - as we transition from one era to another; and/or - whenever the protocol parameters are updated. Finally, since: - this field is for debugging purposes only; - it has maintenance burden that is hard to satisfy; - it is an obstacle to ongoing work in other areas; and since - there is little evidence of user demand for this field, We should feel free to remove it. Source commit: c25031d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants