Small adjustment in CLI #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
reviewed
Jun 11, 2019
exe/wallet/Main.hs
Outdated
| TIO.hPutStr stderr "" | ||
| else do | ||
| TIO.hPutStrLn stderr "Ok." | ||
| BL8.putStrLn (encode a) |
There was a problem hiding this comment.
What's the rational / requirement for the silentMode 🤔 ?
Also, avoid Bool where you can and favor a concrete data-type that conveys the semantic better:
data Mode = Silent | VerboseAlthough here, I don't think we need this ?
There was a problem hiding this comment.
Instead, I'll suggest to:
- split
runClientinto two smaller functions:sendRequesthandleResponse
This way, you may re-use sendRequest easily to check that a wallet exists without doing all the standard handling.
This was referenced Jun 12, 2019
piotr-iohk
force-pushed
the
piotr/397/fix_faulty_exit_code
branch
from
ecbe286 to
fc547e4
Compare
piotr-iohk
commented
Jun 12, 2019
added 4 commits
June 12, 2019 14:42
…sking for passphrase in case wallet does not exist
piotr-iohk
force-pushed
the
piotr/397/fix_faulty_exit_code
branch
from
fc547e4 to
07cd348
Compare
piotr-iohk
force-pushed
the
piotr/397/fix_faulty_exit_code
branch
from
07cd348 to
0dd4c0e
Compare
KtorZ
reviewed
Jun 12, 2019
| ts | ||
| (ApiT wPwd) | ||
| res <- sendRequest $ getWallet $ ApiT wId | ||
| if (isRight res) then do |
There was a problem hiding this comment.
Just a minor thing but pattern-matching case res of Right _; Left _; is more idiomatic in Haskell than if isXXX then else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#397
#398
Overview
Comments