Derive arithmetic operations for {Coin,TokenQuantity}.
#3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanknowles
requested review from
Anviking,
HeinrichApfelmus,
paolino,
paweljakubas and
Unisay
as code owners
jonathanknowles
changed the title
{Coin,TokenQuantity} with monoid-subclasses.{Coin,TokenQuantity} with monoid-subclasses.
jonathanknowles
removed request for
paolino,
HeinrichApfelmus,
Unisay and
paweljakubas
jonathanknowles
changed the title
{Coin,TokenQuantity} with monoid-subclasses.{Coin,TokenQuantity}.
|
bors r+ |
| deriving (Commutative, Semigroup, Monoid, MonoidNull) via Sum Natural | ||
| deriving (LeftReductive, RightReductive, Reductive) via Sum Natural | ||
| deriving (LeftGCDMonoid, RightGCDMonoid, GCDMonoid) via Sum Natural | ||
| deriving (OverlappingGCDMonoid, Monus) via Sum Natural |
There was a problem hiding this comment.
For this PR, the classes we care about are primarily:
MonoidNull: provides thenulloperation:null x == (x == mempty).Reductive: provides the reductive subtraction operation:</> :: m -> m -> Maybe m(this is a partial inverse of<>).Monus: provides the monus (truncated) subtraction operation:<\> :: m -> m -> m
The other classes are superclasses of the classes we're interested in, which means we must derive them too. (It would be nice if there was a way to auto-derive superclasses without explicitly listing them, but there isn't.)
|
Build succeeded: |
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
May 31, 2023
…a=paweljakubas <!-- Detail in a few bullet points the work accomplished in this PR. Before you submit, don't forget to: CODE-OF-CONDUCT.md CODEOWNERS LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Make sure the GitHub PR fields are correct: ✓ Set a good Title for your PR. ✓ Assign yourself to the PR. ✓ Assign one or more reviewer(s). ✓ Link to a Jira issue, and/or other GitHub issues or PRs. ✓ In the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. CODE-OF-CONDUCT.md CODEOWNERS LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Don't waste reviewers' time: ✓ If it's a draft, select the Create Draft PR option. ✓ Self-review your changes to make sure nothing unexpected slipped through. CODE-OF-CONDUCT.md CODEOWNERS LICENSE README.md bors.toml cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json hie-direnv.yaml lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Try to make your intent clear: ✓ Write a good Description that explains what this PR is meant to do. ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding Jira ticket. ✓ Highlight what Testing you have done. ✓ Acknowledge any changes required to the Documentation. --> - [x] Added withdrawal support for multisig - [x] Added withdrawal integration test - [x] Added quit integration test - [x] Make sure getTransaction exposes certificates - shown in integration testing ### Comments <!-- Additional comments, links, or screenshots to attach, if any. --> ### Issue Number adp-2604 <!-- Reference the Jira/GitHub issue that this PR relates to, and which requirements it tackles. Note: Jira issues of the form ADP- will be auto-linked. --> 3970: Derive arithmetic operations for `{Coin,TokenQuantity}`. r=jonathanknowles a=jonathanknowles ## Summary This PR uses classes defined by the [`monoid-subclasses`](https://hackage.haskell.org/package/monoid-subclasses-1.2.3#readme) library to derive the definitions of all arithmetic operations for the `Coin` and `TokenQuantity` types. This takes advantage of the fact that both `Coin` and `TokenQuantity` have `Semigroup` and `Monoid` instances that are identical to those for `Sum Natural`. Co-authored-by: Pawel Jakubas <[email protected]> Co-authored-by: Piotr Stachyra <[email protected]> Co-authored-by: Jonathan Knowles <[email protected]> Source commit: 8622cfd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses classes defined by the
monoid-subclasseslibrary to derive the definitions of all arithmetic operations for theCoinandTokenQuantitytypes.This takes advantage of the fact that both
CoinandTokenQuantityhaveSemigroupandMonoidinstances that are identical to those forSum Natural.