Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADP-2272] remove cli options related to blockfrost mode #3668

Merged
merged 2 commits into from
Dec 20, 2022
Merged

[ADP-2272] remove cli options related to blockfrost mode #3668

merged 2 commits into from
Dec 20, 2022

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Dec 20, 2022 •
edited
Loading

  • remove launch mode for blockfrost backend
  • remove launch specs for blockfrost backend
  • remove documentation related to blockfrost use

Issue Number

ADP-2272

@piotr-iohk
Copy link
Contributor

Note that also docs require the update:

@paolino paolino force-pushed the paolino/ADP-2272/remove-blockfrost-from-cardano-wallet-cli branch from 966a14f to 56992db Compare December 20, 2022 12:26
@paolino paolino changed the base branch from master to HeinrichApfelmus/cleanup-pipelines December 20, 2022 12:31
@paolino paolino requested a review from piotr-iohk December 20, 2022 12:31
@paolino paolino force-pushed the paolino/ADP-2272/remove-blockfrost-from-cardano-wallet-cli branch from 4633735 to 83dda52 Compare December 20, 2022 13:28
@paolino paolino force-pushed the paolino/ADP-2272/remove-blockfrost-from-cardano-wallet-cli branch from 83dda52 to 9d7ed84 Compare December 20, 2022 13:32
@paolino paolino requested a review from piotr-iohk December 20, 2022 14:07
piotr-iohk
piotr-iohk approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Base automatically changed from HeinrichApfelmus/cleanup-pipelines to master December 20, 2022 15:09
@paolino
Copy link
Collaborator Author

paolino commented Dec 20, 2022

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 20, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 8d2fd71 into master Dec 20, 2022
@iohk-bors iohk-bors bot deleted the paolino/ADP-2272/remove-blockfrost-from-cardano-wallet-cli branch December 20, 2022 16:38
WilliamKingNoel-Bot pushed a commit that referenced this pull request Dec 20, 2022
docs: Merge #3668 3668: [ADP-2272] remove cli options related to bloc…
1283309 
…kfrost mode r=paolino a=paolino - [x] remove launch mode for blockfrost backend - [x] remove launch specs for blockfrost backend - [x] remove documentation related to blockfrost use ### Issue Number ADP-2272
 Co-authored-by: paolo veronelli <[email protected]> Source commit: 8d2fd71
@paolino paolino self-assigned this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

Assignees

@paolino paolino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolino @piotr-iohk