Some small fixes to DB.StateMachine module.
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Mock` data type has the convention that each map has a plural name based on the type of value held within the map. For consistency with this convention, the map of wallet ids to private keys should also have a plural name. Similarly, we can use `pks` to represent a map, but `pk` to represent a value within a map.
It previously returned `CreateWalletTwice`, but it should return `CreateThreeWallets`.
This function is always called with the same arguments, so we can safely inline these arguments.
rvl
approved these changes
Jun 4, 2019
1 task
KtorZ
reviewed
Jun 4, 2019
| @@ -453,7 +453,6 @@ lockstep m@(Model _ ws) c (At resp) = Event | |||
| Generator | |||
| -------------------------------------------------------------------------------} | |||
|
|
|||
| -- NOTE 'concat' reads better. | |||
There was a problem hiding this comment.
Note that this comment wasn't obsolete. It gives a justification for disabling hlint below. Hlint suggests to replace use of concat with ++, but concat reads better :)
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Issue #154
PR #259
Overview
This PR makes a number of small fixes to the
Cardano.Wallet.DB.StateMachinemodule:createThreeWallets.Mock.readAfterDelete(since it was always called with the same arguments).