Light-mode: Fixes for Ada balance and rewards

[HeinrichApfelmus]

Issue number

ADP-2013

Overview

This pull request fixes a couple of issues with light-mode, specifically those relating to the ADA and reward balances.

Details

• Fix accidental interchange of regular and collateral inputs in fromInputs.
• Fix usage of wholeList. This function only makes sense when we fetch an entire block — only then do we know that we have the whole list, not just a sublist.
• Use _accountInfoWithdrawableAmount instead of_accountInfoRewardsSum. It looks like the latter function shows all rewards that were ever accumulated, while we want the balance of rewards that can still be withdrawn from the account.
• Fix filtering of transactions for RewardAccount — we only want those transactions that fall within the bounds bhFrom and bhTo.
• Fix sorting of transaction outputs — it turns out that _transactionUtxosOutputs does not necessarily yield the transaction outputs in order, which messes up the output indices.

[Unisay]

Thanks for all the nice improvements as well as the fix :)

[HeinrichApfelmus]

bors merge

[iohk-bors]

Build failed:

• ci/hydra-build:required

  src/Test/Integration/Scenario/API/Byron/Migrations.hs:426:19: 
  1) API Specifications, BYRON_MIGRATIONS, BYRON_MIGRATE_04 - Actual fee for migration is identical to predicted fee.
       From the following response: Left
           ( DecodeFailure "Something went wrong" "Error in $: Failed reading: not a valid json value at 'Somethingwentwrong'" )
       While verifying value:
         ( Status
             { statusCode = 500
             , statusMessage = "Internal Server Error"
             }
         , Left
             ( DecodeFailure "Something went wrong" "Error in $: Failed reading: not a valid json value at 'Somethingwentwrong'" )
         )
       expected: Status {
                   statusCode = 202,
                   statusMessage = "Accepted"
                 }
        but got: Status {
                   statusCode = 500,
                   statusMessage = "Internal Server Error"
                 }

#3441

[HeinrichApfelmus]

bors retry

[iohk-bors]

Build failed:

• ci/hydra-build:required

  Waited longer than 300s to resolve action: "metadata is fetched".
       expected: 3
        but got: 4

  To rerun use: --match "/API Specifications/SHELLEY_STAKE_POOLS/STAKE_POOLS_SMASH_01 - fetching metadata from SMASH works with delisted pools/"

Randomized with seed 114451994

#2331

[HeinrichApfelmus]

bors retry

[iohk-bors]

Build succeeded:

• buildkite/cardano-wallet
• ci/hydra-build:required