Ensure nightly test advances to the correct commit #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The push-branch.sh script needs to advance the linux-tests-pass branch from it's current revision, to the revision the nightly tests were just run on (HEAD). - `git show-ref -s HEAD` doesn't return HEAD, but refs/remotes/origin/HEAD, i.e. the current revision of the default branch (master). Sometimes this lines up with the revision the nightly tests were just run on (HEAD), but sometimes it does not. - Use instead `git rev-parse --verify HEAD`, which always returns HEAD, not refs/remotes/origin/HEAD.
|
Note that the |
|
bors try |
tryBuild failed: |
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
sevanspowell/adp-1584-fix-nightly-test-advance
branch
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments
push-branch.shscript needs to advance the linux-tests-pass branch from it's current revision, to the revision the nightly tests were just run on (HEAD).git show-ref -s HEADdoesn't return HEAD, butrefs/remotes/origin/HEAD, i.e. the current revision of the default branch (master). Sometimes this lines up with the revision the nightly tests were just run on (HEAD), but sometimes it does not.git rev-parse --verify HEAD, which always returns HEAD, not refs/remotes/origin/HEAD.Issue Number
ADP-1584