Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: Upgrade to windows-2022 #3208

Merged
merged 1 commit into from
Mar 30, 2022
Merged

GitHub Actions: Upgrade to windows-2022 #3208

merged 1 commit into from
Mar 30, 2022

Conversation

sevanspowell
Copy link
Contributor

Comments

I've noticed that the GitHub Actions Windows tests seem to be cancelled before they properly start. I believe this might be due to the impending deprecation of windows-2016 environments.

I'm going to try the following to see if it fixes the issue:

Issue Number

ADP-1587

@sevanspowell
GitHub Actions: Upgrade to windows-2022
aa6bdd2 
- The GitHub Actions "windows-2016" environment is soon to be deprecated,
  upgrade to windows-2022.
  - See actions/runner-images#5238.
@jonathanknowles
Copy link
Member

jonathanknowles commented Mar 30, 2022 •
edited
Loading

This seems very sensible.

Given that the deprecation of windows-2016 is planned to occur on April 1st, it seems we have no choice other than to change to windows-2022, at least if we want to continue using GitHub Actions.

@sevanspowell
Copy link
Contributor Author

The other option we have is to use windows-2019. I'm not sure what the meaningful differences are between the two (at least for our purposes). I've chosen windows-2022 simply because it's the most recent.

This article has some information: https://docs.microsoft.com/en-us/windows-server/get-started/whats-new-in-windows-server-2022, but no information especially relevant to us.

I think if the build succeeds, we can take that as a sign that windows-2022 is appropriate for our purposes.

@sevanspowell
Copy link
Contributor Author

The git history also provides no clues to why windows-2016 was chosen over windows-2019 in the past, so I'm guessing it's an arbitrary choice.

@sevanspowell sevanspowell marked this pull request as ready for review March 30, 2022 05:19
@sevanspowell
Copy link
Contributor Author

bors r+

@jonathanknowles
Copy link
Member

bors r-

Temporarily cancelling so that we can try to merge both this PR and #3203 together.

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 30, 2022

Canceled.

@jonathanknowles
Copy link
Member

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 30, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 52507fd into master Mar 30, 2022
@iohk-bors iohk-bors bot deleted the sevanspowell/adp-1587-upgrade-windows-env-github branch March 30, 2022 06:34
WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 30, 2022
docs: Merge #3203 #3208
93d5893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

@jonathanknowles jonathanknowles jonathanknowles approved these changes

@rvl rvl Awaiting requested review from rvl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sevanspowell @jonathanknowles @piotr-iohk