Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix: Constrain hedgehog < 1.1 #3192

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Quick fix: Constrain hedgehog < 1.1 #3192

merged 1 commit into from
Mar 23, 2022

Conversation

sevanspowell
Copy link
Contributor

@sevanspowell sevanspowell commented Mar 22, 2022 •
edited
Loading

  • Constrain the version of hedgehog to < 1.1. Versions >= 1.1 define the Rec
    constructor in Hedgehog, which conflicts with the Rec constructor defined in
    plutus-ir/src/PlutusIR/Generators/AST.hs.
  • This is the quickest way to fix the cardano-wallet nightly build. A more long-term fix would be to upgrade the version of Plutus we are using. To do so, we'd need to do this ticket first: ADP-1545.

@sevanspowell sevanspowell self-assigned this Mar 22, 2022
@sevanspowell
Quick fix: Constrain hedgehog < 1.1
6e69ebd 
- Constrain the version of hedgehog to < 1.1. Versions >= 1.1 define the Rec
  constructor in Hedgehog, which conflicts with the Rec constructor defined in
  plutus-ir/src/PlutusIR/Generators/AST.hs.
@sevanspowell sevanspowell force-pushed the sevanspowell/fix-cardano-nightly branch from bc859a0 to 6e69ebd Compare March 22, 2022 02:47
@paweljakubas
Copy link
Contributor

I had exactly this error when cabal build all last Fri. This was the main reason I switched to nix develop

@sevanspowell
Copy link
Contributor Author

bors try

@sevanspowell sevanspowell marked this pull request as ready for review March 23, 2022 01:33
iohk-bors bot added a commit that referenced this pull request Mar 23, 2022
@iohk-bors
Try #3192:
028b7b5
@sevanspowell sevanspowell requested review from rvl and piotr-iohk March 23, 2022 01:34
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 23, 2022

try

Build succeeded:

@jonathanknowles jonathanknowles self-requested a review March 23, 2022 06:32
@sevanspowell
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Mar 23, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit d2fa0c9 into master Mar 23, 2022
@iohk-bors iohk-bors bot deleted the sevanspowell/fix-cardano-nightly branch March 23, 2022 07:51
WilliamKingNoel-Bot pushed a commit that referenced this pull request Mar 23, 2022
docs: Merge #3192
09325a4
rvl
rvl reviewed Mar 23, 2022
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable to add cabal.project constraints if a dependency cabal file does not define the constraints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvl rvl rvl left review comments

@jonathanknowles jonathanknowles jonathanknowles approved these changes

@piotr-iohk piotr-iohk Awaiting requested review from piotr-iohk

Assignees

@sevanspowell sevanspowell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sevanspowell @paweljakubas @jonathanknowles @rvl