database_schema_version table stores current database schema version.
#3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unisay
force-pushed
the
ADP-1135-add-table-file-format-to-database
branch
4 times, most recently
from
187839e to
ceb5357
Compare
Unisay
force-pushed
the
ADP-1135-add-table-file-format-to-database
branch
from
f5bbf7c to
1018cd2
Compare
Unisay
force-pushed
the
ADP-1135-add-table-file-format-to-database
branch
2 times, most recently
from
4781217 to
f7f5e42
Compare
|
I made the following changes to this PR:
@HeinrichApfelmus do you think this PR is ready to be merged or is there anything else you'd like to add? Thanks. |
Unisay
changed the title
database_metadata table stores current database schema (file format) version.database_schema_version table stores current database schema version.
Unisay
force-pushed
the
ADP-1135-add-table-file-format-to-database
branch
from
0b9b257 to
bda3702
Compare
Unisay
force-pushed
the
ADP-1135-add-table-file-format-to-database
branch
from
bda3702 to
bb41b55
Compare
|
🎆 |
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
…e-file-format-to-database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-1135
This PR adds a database table
database_metadatawith 1 row and 1 column in it:version(from here DV).The idea is that wallet library knows (hardcodes) version of the database file format that it expects to work with (EV), and then:
DV > EVthen its a "database from the future" and no changes should be made to it. Following migrations are aborted.DV < EVthen its a database from the past, and it needs to be migrated (the new mechanism to apply migrations isn't implemented yet)DV = EVthen its all good.