Remove temporary code from CLI for raw server errors + some small error fixes #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
force-pushed
the
KtorZ/260/api-better-errors
branch
from
022bb4f to
8b2e6e2
Compare
KtorZ
commented
May 23, 2019
| @@ -354,7 +356,7 @@ instance LiftHandler ErrCoinSelection where | |||
| [ "I can't process this payment because there's not enough " | |||
| , "UTxO available in the wallet. The total UTxO sums up to " | |||
| , showT utxo, " Lovelace, but I need ", showT payment | |||
| , " Lovelace (inclusive of fee amount) in order to proceed " | |||
| , " Lovelace (exclusive of fee amount) in order to proceed " | |||
There was a problem hiding this comment.
In this case, I would recommend "excluding fee amount".
jonathanknowles
approved these changes
May 23, 2019
KtorZ
force-pushed
the
KtorZ/260/api-better-errors
branch
from
8b2e6e2 to
2009542
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#260
Overview
Comments
This should finalize fixing #260