-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc dev env fixes #2766
Misc dev env fixes #2766
Conversation
We can use nativeBuildInputs now, since NixOS/nixpkgs#103501
ba6024c
to
82e5b64
Compare
.dir-locals.el
Outdated
@@ -0,0 +1,16 @@ | |||
;; Emacs settings for cardano-wallet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I think I'd prefer if this file was renamed to .dir-locals.el.example
or something similar. It's super useful to mine for ideas, but quickly diverges between programmers, and I can't imagine dealing with the merge conflicts being fun, you'd have to stash your local changes every time you pull then pop them afterwards?
That way we could contribute ideas to the example file without having to worry about breaking other's configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you're right.
I will remove it, and use its text as an example in our documentation.
It would be nice to have editors working properly "out of the box."
With VSCode, you can add stuff like recommended plugins and settings into the .vscode
directory.
But perhaps this is too difficult to do for emacs.
@@ -59,15 +59,6 @@ let | |||
|
|||
CARDANO_NODE_CONFIGS = pkgs.cardano-node-deployments; | |||
|
|||
# If any build input has bash completions, add it to the search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, what makes this not necessary anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put a link in the commit message to this: NixOS/nixpkgs#103501
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
82e5b64
to
038f712
Compare
bors r+ |
2766: Misc dev env fixes r=rvl a=rvl ### Issue Number Found while working on #2765. ### Overview This is a mixed bag of small tweaks. - ~Adds `.dir-locals.el` with conservative presets for Emacs users.~ - Add tracing of job names to Hydra evaluation (thanks for the tip @hamishmack) - Delete some unneeded code in `shell.nix` (thanks for the tip @jbgi @nrdxp) - Change `scripts/gen-hie.sh` to make symlinks if `hie.yaml` and `.ghci` don't exist. - `.gitignore` and `.editorconfig` tweaks. Co-authored-by: Rodney Lorrimar <[email protected]>
Build failed:
|
Issue Number
Found while working on #2765.
Overview
This is a mixed bag of small tweaks.
Adds.dir-locals.el
with conservative presets for Emacs users.shell.nix
(thanks for the tip @jbgi @nrdxp)scripts/gen-hie.sh
to make symlinks ifhie.yaml
and.ghci
don't exist..gitignore
and.editorconfig
tweaks.