Wait longer for first tip in restore-bench #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to fix this timeout: https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/964#fb8228aa-158e-4517-b5bb-883e2be30b24 ``` [bench-restore:Notice:15] [2021-05-31 01:01:17.09 UTC] [cardano-node.66880] withBackend action done. Terminating child process restore: UnliftIO.Exception.throwString called with: Gave up in waitForNodeSync, waiting a tip Called from: throwString (bench/Restore.hs:777:18 in main:Main) ``` It might just be the node re-validating its entire state, taking a lot of time. In this case, waiting longer should help.
|
bors r+ |
|
Build succeeded: |
This comment has been minimized.
This comment has been minimized.
|
Fixed this error, but the previous heap exhausted error remains. |
rvl
reviewed
Jun 1, 2021
Yes. We should mostly wait for either the ledger-validation, or full synchronisation, but never both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
ADP-846
Overview
Comments
Attempt to fix this timeout:
https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/964#fb8228aa-158e-4517-b5bb-883e2be30b24
It might just be the node re-validating its entire state, taking a lot
of time. In this case, waiting longer should help.
Update
https://buildkite.com/input-output-hk/cardano-wallet-nightly/builds/966#32b592d5-567d-41b9-91bb-d99d89209506
After a while we start seeing
Initial node synchronization: still restoring (97.04%), so it seems to work.