Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add derivation path assertions in e2e list/post addr tests #2605

Merged
merged 2 commits into from
Apr 8, 2021
Merged

add derivation path assertions in e2e list/post addr tests #2605

merged 2 commits into from
Apr 8, 2021

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

ADP-766

Overview

  • 6391383
    add derivation path assertions in e2e list/post addr tests

  • d799b3e
    remove redundant test

Comments

@piotr-iohk piotr-iohk added the Improvement Mark a PR as an improvement, for auto-generated CHANGELOG label Apr 7, 2021
@piotr-iohk piotr-iohk requested a review from paweljakubas April 7, 2021 08:41
@piotr-iohk piotr-iohk self-assigned this Apr 7, 2021
KtorZ
KtorZ approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Apr 7, 2021
@iohk-bors
Merge #2605
8039e42 
2605: add derivation path assertions in e2e list/post addr tests r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-766


# Overview

- 6391383
  add derivation path assertions in e2e list/post addr tests
  
- d799b3e
  remove redundant test



# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Piotr Stachyra <[email protected]>
paweljakubas
paweljakubas approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 7, 2021 •
edited by piotr-iohk
Loading

Build failed:

#2415

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Apr 7, 2021
@iohk-bors
Merge #2605
3485083 
2605: add derivation path assertions in e2e list/post addr tests r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-766


# Overview

- 6391383
  add derivation path assertions in e2e list/post addr tests
  
- d799b3e
  remove redundant test



# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 7, 2021 •
edited by Anviking
Loading

Build failed:

    parallel puts replace values in _any_ order
      Checkpoint
        +++ OK, passed 100 tests (57% conflicting db entries).
      Wallet Metadata
        +++ OK, passed 100 tests (57% conflicting db entries).
      Tx History
        +++ OK, passed 100 tests (57% conflicting db entries).
      Private Key
        +++ OK, passed 100 tests (57% conflicting db entries).
    rollback
      Can rollback to any arbitrary known checkpoint
        +++ OK, passed 100 tests.
building of '/nix/store/m52f61plbdkypwyr9xyp47pgljc4y57v-cardano-wallet-core-test-unit-2021.3.4-check' timed out after 900 seconds of silence

#2472

@piotr-iohk
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Apr 7, 2021
@iohk-bors
Merge #2605
6d2061d 
2605: add derivation path assertions in e2e list/post addr tests r=piotr-iohk a=piotr-iohk

# Issue Number

ADP-766


# Overview

- 6391383
  add derivation path assertions in e2e list/post addr tests
  
- d799b3e
  remove redundant test



# Comments

<!-- Additional comments or screenshots to attach if any -->

<!--
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding ticket
 ✓ Acknowledge any changes required to the Wiki
 ✓ Finally, in the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages.
-->


Co-authored-by: Piotr Stachyra <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 7, 2021

Build failed:

@rvl
Copy link
Contributor

rvl commented Apr 8, 2021

bors r+

@iohk-bors iohk-bors bot merged commit b0701a9 into master Apr 8, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 8, 2021

Build succeeded:

@iohk-bors iohk-bors bot deleted the piotr/e2e-address-derivation-path branch April 8, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paweljakubas paweljakubas paweljakubas approved these changes

@KtorZ KtorZ KtorZ approved these changes

Assignees

@piotr-iohk piotr-iohk

Labels
Improvement Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@piotr-iohk @rvl @KtorZ @paweljakubas