Add derivation path to api address #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove stack.yaml.lock
6 tasks
paweljakubas
added
the
IMPROVEMENT
KtorZ
approved these changes
Apr 2, 2021
| w <- fixture ctx | ||
| r <- request @[ApiAddress n] ctx (Link.listAddresses @'Byron w) Default Empty | ||
| verify r [ expectResponseCode HTTP.status200 ] | ||
| let n = length $ getFromResponse id r | ||
| forM_ [0..n-1] $ \addrIx -> do | ||
| expectListField addrIx #state (`shouldBe` ApiT Unused) r | ||
| expectListField addrIx #derivationPath (\derPath -> NE.length derPath `shouldBe` derPathSize) r |
| toDerivationPath ix = NE.fromList $ map DerivationIndex | ||
| [ getIndex purposeBIP44 | ||
| , getIndex purposeCIP1852 | ||
| , 0 |
There was a problem hiding this comment.
Okay-ish because we assume the first account. I'd however rather leave a note as comment explaining this hard-coded value.
| constructAddrWithPath path (addr,state) acc = | ||
| (addr, state, toDerivationIndexes path):acc | ||
| retrieveAddrsWithPaPath = | ||
| Map.foldrWithKey constructAddrWithPath [] |
There was a problem hiding this comment.
Suggestion to avoid the extra traversal on pending addresses and also, make the function a bit more symmetric to more clearly see how the output is constructed:
instance KnownAddresses (RndState n) where
knownAddresses s = mconcat
[ toListWithPath (\path (addr, state) -> (addr, state, path))
(discoveredAddresses s)
, toListWithPath (\path addr -> (addr, Unused, path))
(pendingAddresses s)
]
where
toListWithPath
:: (NonEmpty DerivationIndex -> v -> result)
-> Map DerivationPath v
-> [result]
toListWithPath mk =
Map.foldrWithKey
(\path v result -> mk (toDerivationIndexes path) v : result)
[]
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
paweljakubas/ADP-766/add-derivation-path-to-api-address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
adp-766
Overview
Comments